Button styles suddenly changed?

[Ajay Goel]

Hi guys,

Suddenly when I reloaded my extensions today, my buttons look and feel had completely changed (not for the better).

I've been digging in to see why. I had an old Gmail window open, and a new one open, and it seems that the CSS for the InboxSDK library changed today.

On left is old styles.

On right is new styles.

See: https://www.dropbox.com/s/d84pcszpmy49vuf/Screenshot%202018-02-14%2023.19.11.png?dl=0

Was this change intentional? Any chance you'll put it back the way it was?

Thanks,

Ajay

[Aleem Mawani]

Can you show us screenshots of how this is rendering for you?

ᐧ

--
You received this message because you are subscribed to the Google Groups "InboxSDK" group.
To unsubscribe from this group and stop receiving emails from it, send an email to inboxsdk+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/inboxsdk/67c8bf1f-5272-4797-968a-f2b301ffd39b%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Ajay Goel]

Yes, here it is:

https://www.dropbox.com/s/l6k8g6ltziz3xuu/Screenshot%202018-02-15%2000.43.26.png?dl=0

Before, it looked like:

https://www.dropbox.com/s/6ltd8nc02pa3qhl/Screenshot%202018-02-15%2000.44.23.png?dl=0

I've been tinkering with the CSS for the last couple hours trying to get it to look normal again. I think I have it figured out. I'm now adding this code right at the end of the registerMessageViewHandler:

            var elements = document.querySelectorAll('.inboxsdk__compose_sendButton');

            for (var i = 0; i < elements.length; i++) {

                //elements[i].style.removeProperty('background-color');

                elements[i].style.backgroundColor = "transparent";

                elements[i].style.paddingLeft = "0px";

                elements[i].style.paddingRight = "6px";

                elements[i].style.backgroundImage = "none";

                elements[i].style.borderColor = "transparent";

            }

I now have it looking even slightly better than it looked before, so I think I'm okay now, but it was a surprise tonight when I reloaded Gmail to find my button looking so odd.

On Thursday, February 15, 2018 at 12:38:48 AM UTC-6, Aleem Mawani wrote:

Can you show us screenshots of how this is rendering for you?

ᐧ

On Wed, Feb 14, 2018 at 9:21 PM, Ajay Goel <aj...@wordzen.com> wrote:

Hi guys,

Suddenly when I reloaded my extensions today, my buttons look and feel had completely changed (not for the better).

I've been digging in to see why. I had an old Gmail window open, and a new one open, and it seems that the CSS for the InboxSDK library changed today.

On left is old styles.

On right is new styles.

See: https://www.dropbox.com/s/d84pcszpmy49vuf/Screenshot%202018-02-14%2023.19.11.png?dl=0

Was this change intentional? Any chance you'll put it back the way it was?

Thanks,

Ajay

--
You received this message because you are subscribed to the Google Groups "InboxSDK" group.

To unsubscribe from this group and stop receiving emails from it, send an email to inboxsdk+u...@googlegroups.com.

[Ajay Goel]

Below, I meant to say registerComposeViewHandler, not registerMessageViewHandler.

[Aleem Mawani]

Looks like you're overriding styles provided by the SDK. We don't recommend mucking with the styles or DOM that the SDK provides - mostly for this reason. The SDK needs to be able to make changes, usually in response to Gmail (as is the case here) so depending on certain styles or DOM the SDK provides can break your app. 

If you remove your custom styling, it should look correct.

ᐧ

To unsubscribe from this group and stop receiving emails from it, send an email to inboxsdk+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/inboxsdk/1a6fec5b-3e40-4c8e-8ef3-ba16dbed4e8f%40googlegroups.com.

[Ajay Goel]

Yes, you are correct, and I totally understand what you're saying. I'm using the iconClass attribute to set my class, and my class does some non-standard things like adding a background image and setting the width of the button. I know this kind of styling goes against the best practices -- but I started doing this early on when I launched the extension and now I don't want to change the look suddenly on all our users.

Anyway, thanks for your fast response -- and I'm going to see if I can create a similar look without mucking with the styles!

[René Dang]

I had a similar issue. Same style bug. For mew also another problem occured, which was that the text attribute od the addButton method was ignored. The html text content wasn't set anymore for type 'SEND_ACTION'. I even tried the code example of InboxSDK, same error.

[Aleem Mawani]

That looks like a bug, we'll fix that soon.

ᐧ

To unsubscribe from this group and stop receiving emails from it, send an email to inboxsdk+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/inboxsdk/0550860e-5f0b-48f5-a328-e85355f22eed%40googlegroups.com.

[Chaïb Martinez]

Same for me/

The text attribute of the addButton method is not working since the last update :(

[Omar Ismail]

The text property is now being respected again. However this is an undocumented feature and will go away in the future. Please update your code accordingly.

ᐧ

--

You received this message because you are subscribed to the Google Groups "InboxSDK" group.
To unsubscribe from this group and stop receiving emails from it, send an email to inboxsdk+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/inboxsdk/64c9d0d3-e9cd-4f9f-b954-88184913493e%40googlegroups.com.