Theme based on url/server

[Nicolas Micoud]

Hi,

Our SaaS solution is reachable via several urls, according to timezones : americas / emea and we recently added a server for a customer which has lots of users.
Now we would like to change the logo from the login page (and maybe the theme with difference icons) when this dedicated server is used.

In other words, ATM the theme is set at DB level, we would like to be able to set it at server level (tenant level is not enough as the login page doesn't which tenant(s) can be used there).

I haven't tested, but I think changes would be required in ThemeManager.getTheme, with something like:

String theme = System.getProperty(MSysConfig.ZK_THEME + WebUtil.getServerName());
       
if (Util.isEmpty(theme))
    theme = System.getProperty(MSysConfig.ZK_THEME + WebUtil.getHostIP());    

if (Util.isEmpty(theme)) // fallback to the default
    theme = System.getProperty(MSysConfig.ZK_THEME);

In the plugin that will contains themes, we can have :

web\theme\themeTenant1
web\theme\themeTenant2
web\theme\theme192.168.1.10

wdyt?

Thanks,

Nicolas

[Carlos Antonio Ruiz Gomez]

As you say it's a dedicated server for a specific customer, you can do
it at this moment simply setting the variable ZK_THEME in that server
different than the other servers.

I think you can do that setting a global a context variable, something like:
export ZK_THEME=themeDedicatedTenant1



El 16/6/22 a las 17:24, Nicolas Micoud escribió:

> Nicolas --

[Nicolas Micoud]

Hi Carlos,

Indeed, I didn't notice the first retrieval was done using a System.getProperty (I thought it was a MSysConfig.getValue).

So, I try to add export ZK_THEME=default in idempiere service but it was not working.

The only way to make it work was to add it in idempiereInit.properties file.

Do you think is ok this way?

Thanks,

Nicolas

[Carlos Antonio Ruiz Gomez]

xref

https://mattermost.idempiere.org/idempiere/pl/dnsqj4iy3fyczq4yn6fwdr4rjc

El 17/6/22 a las 9:08, Nicolas Micoud escribió:

[Nicolas Micoud]

Hi,

Ability to define the theme on the server is working well, but there are some missing pieces.

ATM, logos and browser icon/title are still read from DB and cannot be set at server level.

Is it ok if I update the related methods and first try to get the value from system properties and if not found, take from DB :

For instance, ThemeManager.getLargeLogo() will be something like:

public static String getLargeLogo() {
    String logo = System.getProperty(ITheme.LOGIN_LOGO_IMAGE);
    if (!Util.isEmpty(logo))
        return logo;

    String theme = getTheme();
    String def = THEME_PATH_PREFIX+theme+ITheme.LOGIN_LOGO_IMAGE;
    return MSysConfig.getValue(MSysConfig.ZK_LOGO_LARGE, def);
}

wdyt?

Thanks

Nicolas

[Heng Sin Low]

getLargeLogo() get from theme and your theme is per server ...

Perhaps you have just picked a bad example to illustrate your need ?

--
You received this message because you are subscribed to the Google Groups "iDempiere" group.
To unsubscribe from this group and stop receiving emails from it, send an email to idempiere+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/idempiere/57e1eff9-c9bd-45c9-9fd2-d1ab2818d02bn%40googlegroups.com.

[Heng Sin Low]

hmm .. looks like I have misread it, msysconfig value takes priority over the theme path, looks like you need it the other way round here.

 

would deactivate the msysconfig record works for you here ?

[Nicolas Micoud]

Correct!

I didn't realize the name were different on the 2 themes I used for my tests.

If they have the same name, logo and browser icon are ok.

I also had to deactivate the related records from AD_SysConfig.

So I think the only thing that cannot be set at server level is the browser title which is read from SysConfig (or from zk.xml).
So, change should be done in DefaultWebAppInit.init(WebApp) ?

[Heng Sin Low]

preference.zul inside theme might works for that, try it out.

To view this discussion on the web visit https://groups.google.com/d/msgid/idempiere/160d5071-20c7-4c9f-8008-457506d0c984n%40googlegroups.com.

[Nicolas Micoud]

I've made the following change in preference.zul :

Original version (line is commented) :

Updated version :

Refresh (Eclipse + browser + Incognito mode) ; iDempiere is still displaying as tab browser.
Did I miss something?

[Heng Sin Low]

Don't remember now the history behind this but it seems this is not implemented in current code.

You can try call AEnv.getDesktop().getWebApp().setAppName("app name") ; in preference.zul (need to add import org.adempiere.webui.apps if it is not in there yet).

To view this discussion on the web visit https://groups.google.com/d/msgid/idempiere/dc1f9f8c-64c4-4962-af85-eb7e0344377an%40googlegroups.com.

[Nicolas Micoud]

Hi,

Is working, thanks

Do you think is worthy to add this in trunk as a comment (same as #ZK_BROWSER_TITLE)?

[Heng Sin Low]

yes, that should replace the not working #ZK_BROWSER_TITLE comment.

To view this discussion on the web visit https://groups.google.com/d/msgid/idempiere/ca0c2605-70cc-439a-9eb5-aab34483f96cn%40googlegroups.com.

[Nicolas Micoud]

see https://groups.google.com/g/idempiere/c/IjkJckKlUn4