clang compile errors

39 views
Skip to first unread message

Wirz

unread,
Mar 15, 2015, 11:13:06 PM3/15/15
to hugi...@googlegroups.com
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi guys,

Could I ask for the following patch to be applied to the hugin code?
When compiling under the current Debian with clang++ 3.5, I get a number
of compile errors which the patch fixes.

cheers, lukas


- --
Do not believe the naysayers who say it cannot be done.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlUGSjUACgkQ1m2kmG8CIy2NgACgqe9XtDIh7ukcU1Klu5ZatmUr
WSwAoLhzWo202PkFq5dqYdlRYx6YJ5Ej
=uc9j
-----END PGP SIGNATURE-----
hugin.patch

T. Modes

unread,
Mar 16, 2015, 2:21:19 PM3/16/15
to hugi...@googlegroups.com

Hi Lukas,


Am Montag, 16. März 2015 04:13:06 UTC+1 schrieb lukas:
Could I ask for the following patch to be applied to the hugin code?
When compiling under the current Debian with clang++ 3.5, I get a number
of compile errors which the patch fixes.

Ah, you are compiling without OpenMP support. You know, that hugin/nona/cpfind/... will then only run single threaded?

I needed to polish your patch a lot before committing:
chunk 3 will break compilation of OpenMP code.
chunk 4 will result in an endless loop.

Please test, if this fixes your errors.

Thomas

Wirz

unread,
Mar 16, 2015, 10:03:06 PM3/16/15
to hugi...@googlegroups.com
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Thomas,

On 17/03/15 07:21, T. Modes wrote:
>
> Hi Lukas,
>
> Am Montag, 16. März 2015 04:13:06 UTC+1 schrieb lukas:
>>
>> Could I ask for the following patch to be applied to the hugin code?
>> When compiling under the current Debian with clang++ 3.5, I get a number
>> of compile errors which the patch fixes.
>
> Ah, you are compiling without OpenMP support. You know, that
> hugin/nona/cpfind/... will then only run single threaded?

For no good reason, yes, I should start doing that.

> I needed to polish your patch a lot before committing:
> chunk 3 will break compilation of OpenMP code.
> chunk 4 will result in an endless loop.

Uuh, I'm sorry, I thought what I was doing was short and harmless, but,
looking at your patch I see that there was more to it.

> Please test, if this fixes your errors.

It does, thank you!


cheers, lukas

- --
Do not believe the naysayers who say it cannot be done.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlUHi0EACgkQ1m2kmG8CIy2djACeKWAMGK4s2bcZ/U6JwwPjT2rA
BOEAoJfEdoNviHcand/vII9+wMIsnl6E
=ttiR
-----END PGP SIGNATURE-----
Reply all
Reply to author
Forward
0 new messages