My first push to sourceforge

[johnfi...@gmail.com]

If I did this right:

I created a branch JohnsWork

I pushed one commit containing phase 1 of changes to add preferences for the behavior of the magnifier in the CP dialog.

In the preferences for the CP dialog, there are three new entries, all in a section named magnifier.  The first two were already hidden preferences (edit in ~/.hugin for linux or in registry for windows).  The third is new.

Half width:  Default 30:  This controls the width in pixels of of the magnifier.  The actual width (and the value stored in ~/.hugin) is 2N+1 of the value given in the preferences GUI.

Scale: Default 3.0:  This is the zoom level inside the magnifier square.  So 3.0 means 3 pixels of screen for each pixel of image.

Relative Scale: Default 0: This controls the behavior of the magnifier for higher levels of zoom of the image itself.  Most of its meaning doesn't become useful until the 400% and 800% zoom levels of the image are available (which I'm using but did not push to sourceforge).

Values:

< 1.0 means keep the old behavior (from before I added this preference item) primarily not displaying the magnifier for zoom level 200% or greater.

1.0 means disable the magnifier when it would not be more zoom than the image zoom.

> 1.0 sets the min magnification of the magnifier as a multiple of the image zoom:  example, if the scale is 3.0 and the Relative Scale is 2.0, the actual magnification would be 3.0 for zoom 100% or less and would be double the zoom for zoom of 200% or more.

I'm still planning to make the changes I described earlier including a preference to change the hiding rules for the magnifier.  But I decided an even smaller first commit was appropriate, in case I'm doing something fundamentally wrong.

Please provide some feedback:

Did I do the push correctly?

Does my branch build for you?

Does this new feature work for you?

Whatever else you might consider wrong?

How do I get the visible text I added into whatever queue exists for text that hasn't been translated yet?

[T. Modes]

johnfi...@gmail.com schrieb am Freitag, 4. Februar 2022 um 02:15:11 UTC+1:

If I did this right:

I created a branch JohnsWork

That's a bad name! All branches contains an name with a description what is implemented in it. And not a name of the coder. (I know, there is an older one with a name. But this one is very old and was used before mercurial. All current branches are using a name with the feature implemented.) But now it's too late to change it…

When later looking on the name, it does say nothing. Also the commit message could be more descriptive. The addition phase 1 says nothing.

Also I would have split this changeset into 2 or even 3 commits instead of mix all 3 things into one.

Scale: Default 3.0:  This is the zoom level inside the magnifier square.  So 3.0 means 3 pixels of screen for each pixel of image.

Hugin is bad in upscaling. When doing high upscales you will often see interpolation artefacts, which is not what the user wants and what is helpful. So I don't see the point of make this configurable.

Relative Scale: Default 0: This controls the behavior of the magnifier for higher levels of zoom of the image itself.  Most of its meaning doesn't become useful until the 400% and 800% zoom levels of the image are available (which I'm using but did not push to sourceforge).

Values:

< 1.0 means keep the old behavior (from before I added this preference item) primarily not displaying the magnifier for zoom level 200% or greater.

1.0 means disable the magnifier when it would not be more zoom than the image zoom.

> 1.0 sets the min magnification of the magnifier as a multiple of the image zoom:  example, if the scale is 3.0 and the Relative Scale is 2.0, the actual magnification would be 3.0 for zoom 100% or less and would be double the zoom for zoom of 200% or more.

Sorry, but an casual user does not understand this logic. This is more confusing than helpful.

Also the last point is not explained in the preferences dialog, only the first and second one are mentioned.

And what means a relative scale of 3.0? And assuming a scale of default 3.0: 300 % magnifier zoom when image zoom is <300 %. And above 300 % image zoom the magnifier zoom is then 3*3 = 900 % or 2*3=600 %? Or what else?

When it needs such a confusing description nobody (except the coder) does really understand it.

Whatever else you might consider wrong?

Please use separate lines for comments and not inline comments.

 

How do I get the visible text I added into whatever queue exists for text that hasn't been translated yet?

This is done during the release cycle. Don't touch the translation files at the current status.

 

[johnfi...@gmail.com]

On Friday, February 4, 2022 at 10:55:04 AM UTC-5 T. Modes wrote:

Hugin is bad in upscaling. When doing high upscales you will often see interpolation artefacts, which is not what the user wants and what is helpful. So I don't see the point of make this configurable.

It already was configurable.  I just changed that from a hidden preference item (changed via regedit in Windows)  to a visible preference item.  I was using that and setting it higher since long before I decided to try to get the build of hugin to work for me.  It certainly is something I wanted as a user.  Maybe it depends on your display resolution whether it is helpful.

Interpolation artifacts don't necessarily prevent the feature from providing better information as you decide whether a manually adjusted CP is in exactly the right place.

A larger width for the magnifier is likely a prerequisite for a larger scale to be useful and a high resolution on your physical display is likely a prerequisite for the larger width to be useful.  I doubt I'm the only user who wants to work that way.  But I suspect I'm in a much smaller minority both in taking the trouble to find out what hugin registry setting would do it and in being comfortable with regedit.

Sorry, but an casual user does not understand this logic. This is more confusing than helpful.

That version of the description was for those who might try to build from my branch, not for casual users.

The tooltip inside the preferences dialog explains the main use.  The two notes on the side explained only the exceptions.  I would also edit the help text.

It may be hard for you to see as a long time user, but most settings in hugin preferences are much harder for inexperienced users to understand.  I'm happy to try to improve it.  But I think I started at better than average.

[T. Modes]

johnfi...@gmail.com schrieb am Freitag, 4. Februar 2022 um 17:18:09 UTC+1:

That version of the description was for those who might try to build from my branch, not for casual users.

Okay, then build you a version to testing and the final version for the casual user is different from this one?

The tooltip inside the preferences dialog explains the main use.  The two notes on the side explained only the exceptions.  I would also edit the help text.

When it needs additional description for all features it is not self-explaining. E.g. the third point was only explained in your mail, but it not obviously for a casual user. 

but most settings in hugin preferences are much harder for inexperienced users to understand. 

But that does not mean to add new settings which are hard to understand.

 

 But I think I started at better than average.

Your tool tip was:

Minimum magnifier scale relative to image zoom 

and

0: no magnifier for zoom>=200%\n1: no magnifier for zoom>=scale

When you consider this better than average..