irq enable/disable

[Hong-Seok Kim]

struct cpu has a field called irp_disable_count. There are also functions that increment and decrement this value (cpu_irq_enable/disable()). When this value becomes zero, arch_irq_disable() is called. When this becomes positive, arch_irq_enable() is called.

But, I cannot find any place that cpq_irq_enable/disable() is called. Is this feature being used? Or is there a plan?

[Andrew Scull]

It looks like those have been there from the start but weren't even used then. I assume they were put there as a means for letting VMs vote on whether the disable interrupts but that isn't how things are going to work in Hafnium for a while. There aren't any plans in the near future for their use.

On Sun, 30 Jun 2019 at 16:10, 'Hong-Seok Kim' via Hafnium <hafnium...@googlegroups.com> wrote:

struct cpu has a field called irp_disable_count. There are also functions that increment and decrement this value (cpu_irq_enable/disable()). When this value becomes zero, arch_irq_disable() is called. When this becomes positive, arch_irq_enable() is called.

But, I cannot find any place that cpq_irq_enable/disable() is called. Is this feature being used? Or is there a plan?

--
You received this message because you are subscribed to the Google Groups "Hafnium" group.
To unsubscribe from this group and stop receiving emails from it, send an email to hafnium-discu...@googlegroups.com.
To post to this group, send email to hafnium...@googlegroups.com.
To view this discussion on the web, visit https://groups.google.com/d/msgid/hafnium-discuss/CAHvD%3DH_LK%2BzLBu3C0Zzop3b1UhRjrR59TAur8vk9ifiNS-GXfQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[Andrew Walbran]

It could have been intended for use by Hafnium rather than VMs, for disabling interrupts during critical sections. But I think currently we just disable interrupts the whole time Hafnium code is running, so it's not needed. We should probably delete the unused code.

To view this discussion on the web, visit https://groups.google.com/d/msgid/hafnium-discuss/CADcWuH1MpTT_UJENNZ4isk8N_4-%2B4t2rhfeLB9yxPP6bTMmDLw%40mail.gmail.com.

[Hong-Seok Kim]

Yes, I agree. 

2019년 7월 3일 (수) 오전 3:48, Andrew Walbran <qwa...@google.com>님이 작성: