Terrible synchronized method blocking in application.

[Jeremy Whiting]

Hi,

 I am seeing the Gerrit application with terrible performance. One of the bottlenecks is this call path. Which is caused by an instrumentation project calling an unsupported method on the Connection.isWrappedFor method.

Stack Trace    Count    Percentage
String org.h2.message.TraceSystem.format(String, String)    194278    97.4 %
void org.h2.message.TraceSystem.write(int, String, String, Throwable)    194278    97.4 %
void org.h2.message.Trace.error(Throwable, String)    194278    97.4 %
SQLException org.h2.message.TraceObject.logAndConvert(Exception)    194278    97.4 %
SQLException org.h2.message.TraceObject.unsupported(String)    194278    97.4 %
boolean org.h2.jdbc.JdbcConnection.isWrapperFor(Class)    194278    97.4 %
Connection io.opentelemetry.javaagent.instrumentation.jdbc.JdbcUtils.connectionFromStatement(Statement)    194278    97.4 %
DbRequest io.opentelemetry.javaagent.instrumentation.jdbc.DbRequest.create(Statement, String)    194278    97.4 %
DbRequest io.opentelemetry.javaagent.instrumentation.jdbc.DbRequest.create(PreparedStatement)    194278    97.4 %
int org.h2.jdbc.JdbcPreparedStatement.executeUpdate()    102517    51.4 %

 I have a proposal. That the trace message be logged with a level of Info rather than Error.

 The change is best added here to the control flow

https://github.com/h2database/h2database/blob/0b480739b51e264a369606e6cbdb77e09782cc20/h2/src/main/org/h2/message/TraceObject.java#L370-L374

 Checking for an errorcode of 50100.

https://github.com/h2database/h2database/blob/master/h2/src/main/org/h2/api/ErrorCode.java#L525

 Does this proposal to change the trace level pose concerns ?

Regards,

Jeremy

[Evgenij Ryazanov]

Hello!

This method is implemented since H2 1.4.181 Beta released in 2014, only older versions call TraceObject.unsupported() from it. It means that application uses some outdated and unsupported version of H2.

[Jeremy Whiting]

 Hi,

  Yes it will be outdated version of H2.

  Thanks for letting me know it's an unsupported version.

Jeremy