thread manager unlimited number of threads

50 views
Skip to first unread message

xiang...@gmail.com

unread,
Apr 27, 2017, 2:54:01 PM4/27/17
to grpc.io
Hi all, 

I was playing with helloworld sync server example.
I found that the sync server will create as many threads as possible to service incoming request. 
there is max_poller/min_poller option to set, but it doesn't limit total number of threads. 
after reading thread_manager.cc, it looks like they only control number of idle threads and the total number of threads is unlimited. 
Is it by design or something need to fix?

Regards, 
Siyuan

Sree Kuchibhotla

unread,
Apr 28, 2017, 6:39:59 PM4/28/17
to xiang...@gmail.com, grpc.io
Hi Siyuan,
Yes, it would be nice to limit the total number of threads; It was a minor design oversight and we do intend to fix it at some point in future (happy to take a pull request).

thanks
Sree

--
You received this message because you are subscribed to the Google Groups "grpc.io" group.
To unsubscribe from this group and stop receiving emails from it, send an email to grpc-io+unsubscribe@googlegroups.com.
To post to this group, send email to grp...@googlegroups.com.
Visit this group at https://groups.google.com/group/grpc-io.
To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/def4223f-039e-4339-9590-17346da2a57d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply all
Reply to author
Forward
0 new messages