L59 : Allow C++ standard library in gRPC Core Library

65 views
Skip to first unread message

Esun Kim

unread,
Aug 20, 2019, 7:30:29 PM8/20/19
to grpc.io

Please let me know if you have any concerns.

Christopher Warrington - MSFT

unread,
Aug 20, 2019, 9:54:13 PM8/20/19
to grpc.io
On Tuesday, August 20, 2019 at 4:30:29 PM UTC-7, Esun Kim wrote:

> This is the discussion thread for L59 - Allow C++ standard library in gRPC
> Core Library

The biggest thing I see missing from this proposal is how it affects
platforms other than Linux. There is no mention of macOS or Windows. I
assume that only the intersection of the C++11 features supported in the
manylinux1 standard library, MSVC 2015 and later, and similar on macOS can
be used.

For Windows, in particular, it may be worth mentioning that pre-compiled
gRPC releases statically link the C++ runtime, so this proposal should not
affect packaging or deployment. (This is the case for C#. Not sure about how
the other language wrappers work.)

--
Christopher Warrington
Microsoft Corp.

Esun Kim

unread,
Aug 22, 2019, 11:30:09 AM8/22/19
to grpc.io
That's a good point. I'll update the doc to include more about platform-specific issues.

Main reason I didn't mention MacOS and Windows is that it's relatively easy to have this because both Windows and MacOS are more centralized. On Windows, as you said, static linking has been adapted to gRPC prebuilt libraries so mostly it shouldn't matter. On MacOS, libc++.so and libstdc++.so are preinstalled for years so it's fairly reasonable to assume that those are there.

Christopher Warrington - MSFT

unread,
Aug 27, 2019, 6:09:28 PM8/27/19
to grpc.io
On Thursday, August 22, 2019 at 8:30:09 AM UTC-7, Esun Kim wrote:

> That's a good point. I'll update the doc to include more about
> platform-specific issues.

I just saw the updates to the proposal [1]. They look good to me. Thank you.

[1]: https://github.com/grpc/proposal/pull/156
Reply all
Reply to author
Forward
0 new messages