grpc-java supports apache thrift but there isn't a official compiler/generator?

Mathias Gruschinske

unread,

Aug 14, 2016, 9:17:10 AM8/14/16

to grpc.io

Hi guys,

if I am right, with the thrift integration pull request (https://github.com/grpc/grpc-java/pull/2023) came Apache Thrift support but there isn't a official compiler/generator?

I only found this repo https://github.com/chedeti/thrift with a grpc generator. Is it planed to merge it with the official Apache Thrift repo? There isn't any Jira issue or Pull Request to address it.

-Mathias

Vijay Pai

unread,

Aug 15, 2016, 1:36:32 PM8/15/16

to grpc.io

Hello there,

The compiler is still in code review pending a merge. You can see it at https://github.com/grpc/grpc/pull/7594 . We will eventually try to upstream this into Apache Thrift but for now it works by patching against an existing commit of Thrift.

Best regards,

Vijay

Mathias Gruschinske

unread,

Aug 15, 2016, 1:59:13 PM8/15/16

to grpc.io

Thank you for your reply! I haven't seen this pull request. I'm just confused that the Apache Thrift integration for Java is already merged.

Vijay Pai

unread,

Aug 15, 2016, 5:33:34 PM8/15/16

to grpc.io

Right, the grpc-java part got merged a little before the full system was ready since we could already test it out. Feel free to try out the compiler from the PR, though! The content is there and ready for folks to experiment with. In fact, I've approved the code, but haven't merged it yet because I want to make sure that the installation is truly seamless.

We'd appreciate any feedback that you have on it: it's still an early experimental version, but we'll move it forward as we get more users for it.