Re: grpc-node Any support

[Michael Lumish]

That pull request is good to see. I think it means that "Any" types will probably work well with the new package. We generally make announcements on our mailing list grp...@googlegroups.com, and we will make announcements about that package.

On Mon, Mar 5, 2018 at 7:42 PM Adrien Pajot <apa...@google.com> wrote:

Thanks for the blazing fast response!

Regarding the protobuf issue I was looking into the commit and found a few related ones:

https://github.com/dcodeIO/protobuf.js/search?q=any&type=Commits&utf8=%E2%9C%93

And specifically:

https://github.com/dcodeIO/protobuf.js/pull/768

Which.. seems to be adding support?

Good to know for grpc-protobufjs, will keep an eye out,  I assume there will be some kind of announcement when it will be the official new way to do things? Do you have an ETA?

On Mon, Mar 5, 2018 at 7:31 PM Michael Lumish <mlu...@google.com> wrote:

Yes, posting a GitHub issue there is generally the best way to bring an issue to our attention.

Regarding your specific issue, it may not actually be fixed in Protobuf.js. That issue you point to is closed, but only because that project's maintainer closed a lot of issues as obsolete when they released Protobuf.js 6. If it is fixed, you may be interested in our upcoming package for using gRPC with Protobuf.js, currently in development in https://github.com/grpc/grpc-node/tree/master/packages/grpc-protobufjs. It is currently untested and undocumented, but in the future it will be the recommended way to use gRPC with the newest version of Protobuf.js. You may also want to reopen the Protobuf.js issue that you linked to, and ask whether it is fixed in the newest version of Protobuf.js.

On Mon, Mar 5, 2018 at 7:09 PM Adrien Pajot <apa...@google.com> wrote:

Hi Michael!

I am part of Hire (a G Suite app that runs on Node JS). I saw that you are one on the main contributor for https://github.com/grpc/grpc-node.

I was looking around to see if the library supports the "Any" type but didn't see any mention of that.

I saw that protobuf.js had the same limitation but fixed it: https://github.com/dcodeIO/protobuf.js/issues/435

For now I wrote my own pack and unpack functions, haven't tested it end to end yet but it seems to be working.

Not sure what's the process as a Googler, should I just post this to https://github.com/grpc/grpc-node/issues with my personal Github account?

Thanks!

Adrien