[xds_client] pass channel arguments to xds server channel creation

[Yi-Shu Tai]

Hey folks,

I am sorry if this is already documented somewhere please point me if there is any doc.

In our use cases, we'd like to pass "grpc.enable_http_proxy" and "grpc.ssl_target_name_override" as channel arguments to create the channel to xds server. Is there any supported API for this purpose?

yishu

--

戴翊書

Yi-Shu Tai

Software Engineer @Dropbox

[Mark D. Roth]

We don't have a way to pass arbitrary channel args to the xDS channel today.

Passing the grpc.enable_http_proxy arg probably isn't necessary, since you can instead use the $grpc_proxy environment variable to enable use of the proxy.

Passing grpc.ssl_target_name_override wouldn't actually help you today, since we currently don't have a way to use SSL creds for the xDS channel.  That's on our roadmap, though.

--
You received this message because you are subscribed to the Google Groups "grpc.io" group.
To unsubscribe from this group and stop receiving emails from it, send an email to grpc-io+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/CAK%2B0oQEu_b%2ByhdzitNSHrDDW7Q15U3ZVZ%2BRezQXRQx6eiNO1Lw%40mail.gmail.com.

--

Mark D. Roth <ro...@google.com>
Software Engineer
Google, Inc.

[Yi-Shu Tai]

Hey Mark,

Thanks for the reply.

Instead we want to disable the proxy. We somehow have HTTP_PROXY set in some services. For the second question, I forgot to mention that we also want to use custom certs for our infrastructure. 

but yeah, I am not able to find an api so I did some local patches. We don't want to diverge from the upstream forever. Are there any issues we can track? I am happy to file one if there is no

Thanks

yishu

[Mark D. Roth]

On Mon, Nov 9, 2020 at 12:11 PM Yi-Shu Tai <echo...@gmail.com> wrote:

Hey Mark,

Thanks for the reply.

Instead we want to disable the proxy. We somehow have HTTP_PROXY set in some services. For the second question, I forgot to mention that we also want to use custom certs for our infrastructure. 

Can you just unset the env var?

 

but yeah, I am not able to find an api so I did some local patches. We don't want to diverge from the upstream forever. Are there any issues we can track? I am happy to file one if there is no

I don't think we have an issue open specifically for this, but it's definitely on our radar.  We're currently working on some security features, and once that's done, we'll have the infrastructure we need to use those features for the xDS channel itself.

[Yi-Shu Tai]

> Can you just unset the env var?

I want to, but unfortunately no.

okay. Sounds good to me. We can live with local patches for a while. I will keep eyes on related changes.

[Mark D. Roth]

If you're living with local hacks anyway, you may be able to use this internal function to set channel args:

https://github.com/grpc/grpc/blob/4ac9c6f755463a2321f84b0cb2d631e1828faedb/src/core/ext/xds/xds_client.h#L325

To be clear, this is not a public API, and we do not promise not to break it.  But if you're making your own local hacks anyway, you might be able to leverage that.  Just make sure to call it before the first xDS channel is created.

[Yi-Shu Tai]

Thanks for the info. This is better than we have in local hacks