Proposal: true binary encoding for metadata

145 views
Skip to first unread message

Craig Tiller

unread,
Mar 29, 2017, 1:11:05 PM3/29/17
to grp...@googlegroups.com
I've created a gRFC here https://github.com/grpc/proposal/pull/19 for a protocol change to allow -bin metadata elements to be transmitted in binary form.

Eric Anderson

unread,
Mar 29, 2017, 1:28:41 PM3/29/17
to Craig Tiller, grp...@googlegroups.com
On Wed, Mar 29, 2017 at 10:10 AM, 'Craig Tiller' via grpc.io <grp...@googlegroups.com> wrote:
I've created a gRFC here https://github.com/grpc/proposal/pull/19 for a protocol change to allow -bin metadata elements to be transmitted in binary form.

The proposal LGTM. I made some comments on the PR for editorial changes.

Josh Humphries

unread,
Mar 29, 2017, 2:39:19 PM3/29/17
to Eric Anderson, Craig Tiller, grp...@googlegroups.com
Very cool.

----
Josh Humphries
jh...@bluegosling.com

--
You received this message because you are subscribed to the Google Groups "grpc.io" group.
To unsubscribe from this group and stop receiving emails from it, send an email to grpc-io+unsubscribe@googlegroups.com.
To post to this group, send email to grp...@googlegroups.com.
Visit this group at https://groups.google.com/group/grpc-io.
To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/CA%2B4M1oMo846Xvxujfh7QE9rWKRQ-i_AxfyeoHda%2BNYXjKJzVRg%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

Louis Ryan

unread,
Apr 7, 2017, 6:49:19 PM4/7/17
to Josh Humphries, Eric Anderson, Craig Tiller, grp...@googlegroups.com, Piotr Sikora
Can you elaborate in the spec on why the NUL prefix is needed? You mention the alternatives but not why this is being done, I presume it's to disambiguate with base64 encoded stuff while setting negotiation is in flight.

Otherwise LGTM

+cc Piotr re our recent discussion about the IETF proposal for 'JSON' (!) headers  https://tools.ietf.org/html/draft-ietf-httpbis-jfv-02


Craig Tiller

unread,
Apr 7, 2017, 7:08:28 PM4/7/17
to Louis Ryan, Josh Humphries, Eric Anderson, grp...@googlegroups.com, Piotr Sikora
Right... we don't have an ack on the settings negotiation (which keeps things simple) but there's otherwise no way to disambiguate base64 - and the NUL has the nice property of being otherwise disallowed by http2.

On Fri, Apr 7, 2017 at 3:49 PM Louis Ryan <lr...@google.com> wrote:
Can you elaborate in the spec on why the NUL prefix is needed? You mention the alternatives but not why this is being done, I presume it's to disambiguate with base64 encoded stuff while setting negotiation is in flight.

Otherwise LGTM

+cc Piotr re our recent discussion about the IETF proposal for 'JSON' (!) headers  https://tools.ietf.org/html/draft-ietf-httpbis-jfv-02


On Wed, Mar 29, 2017 at 11:38 AM, Josh Humphries <jh...@bluegosling.com> wrote:
Very cool.

----
Josh Humphries
jh...@bluegosling.com

On Wed, Mar 29, 2017 at 1:28 PM, 'Eric Anderson' via grpc.io <grp...@googlegroups.com> wrote:
On Wed, Mar 29, 2017 at 10:10 AM, 'Craig Tiller' via grpc.io <grp...@googlegroups.com> wrote:
I've created a gRFC here https://github.com/grpc/proposal/pull/19 for a protocol change to allow -bin metadata elements to be transmitted in binary form.

The proposal LGTM. I made some comments on the PR for editorial changes.

--
You received this message because you are subscribed to the Google Groups "grpc.io" group.
To unsubscribe from this group and stop receiving emails from it, send an email to grpc-io+u...@googlegroups.com.

To post to this group, send email to grp...@googlegroups.com.
Visit this group at https://groups.google.com/group/grpc-io.

--
You received this message because you are subscribed to the Google Groups "grpc.io" group.
To unsubscribe from this group and stop receiving emails from it, send an email to grpc-io+u...@googlegroups.com.

To post to this group, send email to grp...@googlegroups.com.
Visit this group at https://groups.google.com/group/grpc-io.
Reply all
Reply to author
Forward
0 new messages