PR approval process

[Arpit Baldeva]

Hi,

Is there any recommended process to get the PR approved and merged? I submitted a PR a while back (https://github.com/grpc/grpc/pull/10919 ) and it is still waiting for a reviewer and CLA verification. I am also unsure how to select/assign a person as the reviewer.

Thanks.

[Varun Talwar]

Assigned to Lisa who can help review and merge the docs.

--
You received this message because you are subscribed to the Google Groups "grpc.io" group.
To unsubscribe from this group and stop receiving emails from it, send an email to grpc-io+unsubscribe@googlegroups.com.
To post to this group, send email to grp...@googlegroups.com.
Visit this group at https://groups.google.com/group/grpc-io.
To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/3b506a2c-008b-4cdb-9340-d4c16e7a3205%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Varun Talwar | Product Manager | varun...@google.com | 415-341-7352

[Kailash Sethuraman]

Hi Arpit

We'll take a look at the PR. The CLA needs to be signed as per https://cla.developers.google.com/clas.  

Do make sure that you are signing it with the same email account associated with the pull request. 

It's perfectly fine to ping the group as you have done or just update the existing discussion with a pointer to the PR. 

On Thu, May 11, 2017 at 11:09 AM, Arpit Baldeva <abal...@gmail.com> wrote:

--

[Arpit Baldeva]

Thanks for the info.

I did sign the CLA and noted that in the PR (The bot instruction seemed to me that way). I assume that is sufficient?

Thanks. 

On Thursday, May 11, 2017 at 11:25:47 AM UTC-7, Kailash Sethuraman wrote:

Hi Arpit

We'll take a look at the PR. The CLA needs to be signed as per https://cla.developers.google.com/clas.  

Do make sure that you are signing it with the same email account associated with the pull request. 

It's perfectly fine to ping the group as you have done or just update the existing discussion with a pointer to the PR. 

On Thu, May 11, 2017 at 11:09 AM, Arpit Baldeva <abal...@gmail.com> wrote:

Hi,

Is there any recommended process to get the PR approved and merged? I submitted a PR a while back (https://github.com/grpc/grpc/pull/10919 ) and it is still waiting for a reviewer and CLA verification. I am also unsure how to select/assign a person as the reviewer.

Thanks.

--
You received this message because you are subscribed to the Google Groups "grpc.io" group.

To unsubscribe from this group and stop receiving emails from it, send an email to grpc-io+u...@googlegroups.com.

[Lisa Carey]

Sure, I'll take a look and sorry it took me a while to get to, I think it slipped through the net because the CLA hadn't been verified. Will get back to you with review comments ASAP.

--

Varun Talwar | Product Manager | varuntalwar@google.com | 415-341-7352

--

Google Ireland Ltd. : Registered in Ireland with company number 368047.
Gordon House, Barrow Street, Dublin 4, Ireland.

[Lisa Carey]

Actually I see why it slipped through the net, it's being submitted to grpc/doc rather than grpc.github.io, which is where I look out for doc PRs.

Is this appropriate for grpc.io (it looks v useful) rather than just the repo, and is it C++ specific or applicable to any language version that comes in sync and async flavours?

[Arpit Baldeva]

Hmm...the docs in the repo are in the .md format and as per the discussion here(https://groups.google.com/forum/#!topic/grpc-io/DuBDpK96B14 ) , the ask was to submit a PR in the .md format.

I think it makes sense to go it in the repo as I see other similar docs there too. As for the grpc.io itself, while I think the doc can go there too, I am not sure about the process around it.

The doc was written while working with C++ code base. I am unsure how much of it translates to the other languages as I have no expertise with them.

Thanks.   

On Thursday, May 11, 2017 at 2:01:40 PM UTC-7, Lisa Carey wrote:

Actually I see why it slipped through the net, it's being submitted to grpc/doc rather than grpc.github.io, which is where I look out for doc PRs.

Is this appropriate for grpc.io (it looks v useful) rather than just the repo, and is it C++ specific or applicable to any language version that comes in sync and async flavours?

On Thu, May 11, 2017 at 9:55 PM, Lisa Carey <lca...@google.com> wrote:

Sure, I'll take a look and sorry it took me a while to get to, I think it slipped through the net because the CLA hadn't been verified. Will get back to you with review comments ASAP.

On Thu, May 11, 2017 at 7:12 PM, Varun Talwar <varun...@google.com> wrote:

Assigned to Lisa who can help review and merge the docs.

On Thu, May 11, 2017 at 11:09 AM, Arpit Baldeva <abal...@gmail.com> wrote:

Hi,

Is there any recommended process to get the PR approved and merged? I submitted a PR a while back (https://github.com/grpc/grpc/pull/10919 ) and it is still waiting for a reviewer and CLA verification. I am also unsure how to select/assign a person as the reviewer.

Thanks.

--
You received this message because you are subscribed to the Google Groups "grpc.io" group.

To unsubscribe from this group and stop receiving emails from it, send an email to grpc-io+u...@googlegroups.com.

To post to this group, send email to grp...@googlegroups.com.
Visit this group at https://groups.google.com/group/grpc-io.
To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/3b506a2c-008b-4cdb-9340-d4c16e7a3205%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Varun Talwar | Product Manager | varun...@google.com | 415-341-7352

--

Google Ireland Ltd. : Registered in Ireland with company number 368047.
Gordon House, Barrow Street, Dublin 4, Ireland.

[Lisa Carey]

The docs on grpc.io are also .md files! :)

We're actually trying to move away from having docs in the repo and not on the site where possible as it means some useful info isn't as easy to find as it could be, but if it's not clear (yet) where this would fit, I'll review in its current location and we can move it if necessary.