Edge property drop error in 3.4.5

[Philip Graff]

Hi all,

I've noticed a bug when dropping edge properties introduced with 3.4.5. I ran the following groovy script on both 3.4.4 and 3.4.5.

g = TinkerFactory.createModern().traversal()

g.V().property("myprop", true).iterate()

System.out.println(g.V().has("myprop").count().next())

g.V().properties("myprop").drop().iterate()

System.out.println(g.V().has("myprop").count().next())

g.E().property("myprop", true).iterate()

System.out.println(g.E().has("myprop").count().next())

g.E().properties("myprop").drop().iterate()

System.out.println(g.E().has("myprop").count().next())

:x

In 3.4.4, it prints:

6

0

6

0

In 3.4.5, it prints:

6

0

6

5

#!/bin/sh

for VERSION in "3.4.4" "3.4.5"

do

./apache-tinkerpop-gremlin-console-${VERSION}/bin/gremlin.sh -i testDrop.groovy

done

For the moment, I've gone back to 3.4.4.

Cheers,

Phil

[Stephen Mallette]

It seems we have a bit of an unwelcome side-effect of:

http://tinkerpop.apache.org/docs/3.4.5/upgrade/#_properties_equality 

https://issues.apache.org/jira/browse/TINKERPOP-2318

LazyBarrierStrategy injects itself and starts bulking things. for 3.4.5 I guess the workaround is to remove that strategy if you are trying to explicitly drop() edge (or meta) properties:

gremlin> g.withoutStrategies(LazyBarrierStrategy).E().properties("myprop").drop()
gremlin> g.E().has("myprop").count().next()
==>0

I think the change at TINKERPOP-2318 was still good so I don't think the answer is to revert the change. 

https://issues.apache.org/jira/browse/TINKERPOP-2338 

 

--
You received this message because you are subscribed to the Google Groups "Gremlin-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to gremlin-user...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/gremlin-users/36323fba-8858-47c6-a4db-0890efb50336%40googlegroups.com.

[Stephen Mallette]

Note that there is currently discussion on the dev list regarding release of 3.4.6 to fix this issue:

https://lists.apache.org/thread.html/r7de7d160173d0774720b347122409bb6e46268613205b08edaa687ee%40%3Cdev.tinkerpop.apache.org%3E 

We now have a fix that appears to be working and passing all tests at - it's about ready for review, i'm just reflecting on the change a bit to be sure there's nothing else to add::

 https://github.com/apache/tinkerpop/pull/1245

I've pushed the 3.4.6-SNAPSHOT to the Apache repo in case anyone wants to try it out to see if it works in their environment.

Philip Graff, thanks for bringing this issue to our attention so quickly. 

[Philip Graff]

Thank you for the quick response and solution. I found it because the bad drop caused one of my unit tests to fail. It took a little digging to figure out the reason. I can try 3.4.6-SNAPSHOT and report back if it works.

Phil 

You received this message because you are subscribed to a topic in the Google Groups "Gremlin-users" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/gremlin-users/wB0a9uP98Zw/unsubscribe.
To unsubscribe from this group and all its topics, send an email to gremlin-user...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/gremlin-users/CAA-H43-_5dfvuLEZx_cRgJVcrL2NV7xBrbPf_T4NjqcxHTCx8Q%40mail.gmail.com.

--

Philip B. Graff

[Philip Graff]

3.4.6-SNAPSHOT passes my test that failed with 3.4.5.

Thanks,

Phil

[Stephen Mallette]

nice - thank you for taking the time to confirm. 

--
You received this message because you are subscribed to the Google Groups "Gremlin-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to gremlin-user...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/gremlin-users/b02e4bee-3d20-4bec-a875-ddfcde75a143%40googlegroups.com.