Question about features and unit tests

[Jonathan Ellithorpe]

I want to confirm that VertexPropertyFeatures.FEATURE_ADD_PROPERTY refers to adding meta properties to vertex properties. So if this feature is supported, then VertexFeatures.FEATURE_META_PROPERTIES must also be set to true. 

I ask because the FeatureRequirementSet.Package.SIMPLE (this is for the unit tests) set of feature requirements includes VertexPropertyFeatures.FEATURE_ADD_PROPERTY, which is odd... because tests like shouldPersistDataOnClose() require the FeatureRequirementSet.Package.SIMPLE feature set to be supported, but does not use meta properties. For a graph database that doesn't have meta properties supported, the test for persistence will not run. Is this right?

[Stephen Mallette]

When I first read this, I thought I immediately knew the answer, then I looked at the code and I was given pause.  It seems that we do have two features that mean the same thing.  I guess the answer is that we need to deprecate one. Also, you're right that SIMPLE might be reviewed for what it's being applied to. I've brought both issues up on the dev list for discussion....

https://pony-poc.apache.org/thread.html/Zn7fzlygehgxjc5

btw, if you are working on a TinkerPop implementation you should consider joining the list:

http://mail-archives.apache.org/mod_mbox/incubator-tinkerpop-dev/

These were good finds btw - if you'd like to collaborate on a PR to help fix this stuff up, please reply to the dev list thread and we can discuss further when the JIRA tickets are created after community feedback.

On Sat, Nov 21, 2015 at 1:07 AM, Jonathan Ellithorpe <jdelli...@gmail.com> wrote:

I want to confirm that VertexPropertyFeatures.FEATURE_ADD_PROPERTY refers to adding meta properties to vertex properties. So if this feature is supported, then VertexFeatures.FEATURE_META_PROPERTIES must also be set to true. 

I ask because the FeatureRequirementSet.Package.SIMPLE (this is for the unit tests) set of feature requirements includes VertexPropertyFeatures.FEATURE_ADD_PROPERTY, which is odd... because tests like shouldPersistDataOnClose() require the FeatureRequirementSet.Package.SIMPLE feature set to be supported, but does not use meta properties. For a graph database that doesn't have meta properties supported, the test for persistence will not run. Is this right?

--
You received this message because you are subscribed to the Google Groups "Gremlin-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to gremlin-user...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/gremlin-users/142bf41a-756a-456f-a75b-99d886cc7e5d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Jonathan Ellithorpe]

Hi Stephen, thanks for the quick response on this. I've sent an e-mail to dev-subscribe to get on the mailing list, waiting to be added.

I'd be up for helping to fix this. When I get subscribed I'll reply to the dev list thread. I am indeed working on an implementation of TinkerPop3, and there are a few other points of pain I've encountered along the way. Perhaps in time I could bring those up for discussion as well.

Jonathan