[DISCUSS][C++] Change the default namespace from `GraphArchive` to `graphar`

[weibin.zen]

Hi all,

I would like proposing to change the default namespace of C++ library from `GraphArchive` to `graphar`.

As I know, the convention of apache project namespace should be all low-case like std, arrow[1], opendal[2]. And the current default namespace `GraphArchive` is not equal to our project name GraphAr.

Please let me know your thoughts.

[1] https://github.com/apache/arrow
[2] https://github.com/apache/opendal

Best

weibin.zen

[李雪(有理)]

I agree that adopting a lowercase namespace (graphar) would adhere to the standard practice, and also reflect our project's name more accurately.

------------------------------------------------------------------

发件人：weibin.zen <weibi...@gmail.com>

发送时间：2024年3月21日(星期四) 14:26

收件人：graphar<gra...@googlegroups.com>

主　题：[DISCUSS][C++] Change the default namespace from `GraphArchive` to `graphar`

--
You received this message because you are subscribed to the Google Groups "GraphAr" group.
To unsubscribe from this group and stop receiving emails from it, send an email to graphar+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/graphar/4d9194ef-fd26-4d16-8609-5e28a8f61563%40Spark.
For more options, visit https://groups.google.com/d/optout.

[曾维彬(樵子)]

Thanks for the reply, and by the way, The setting namespace with cmake would still exists to not break down the SDK previous.

------------------------------------------------------------------

发件人：'李雪(有理)' via GraphAr <gra...@googlegroups.com>

发送时间：2024年3月22日(星期五) 13:59

收件人："weibin.zen"<weibi...@gmail.com>; graphar<gra...@googlegroups.com>

主　题：回复：[DISCUSS][C++] Change the default namespace from `GraphArchive` to `graphar`

To view this discussion on the web visit https://groups.google.com/d/msgid/graphar/9025a1ec-41d7-45fd-a6f5-7b603c91c7cd.youli.lx%40alibaba-inc.com.

[thes...@qq.com]

I agree with that. And it's not too complex as I know.

Besides, should we consider rename the package(top directory) name from `gar` to `graphar` also?

[weibin.zen]

That's good advice. But rename the package name may break down the old version integration code.

BTW, maybe we can reorganize the cpp code by unifying the include and src to  only a src directory like most c++ project[1][2][3]. That would bring much benefits. This is another issue we can discuss and I would open a discussion for that.

[1] https://github.com/apache/incubator-pegasus
[2] https://github.com/apache/arrow/tree/main/cpp
[3] https://github.com/apache/kvrocks

Best

weibin.zen

在 2024年3月22日 +0800 21:08，weibin.zen <weibi...@gmail.com>，写道：

That's good advice. But rename the package name may break down the old version integration code. BTW, maybe we can reorganize the cpp code by unifying the include and src to  only a src directory like most c++ project[1][2][3]. That would bring much benefits. This is another issue we can discuss and I would open a discussion for that. [1] https://github.com/apache/incubator-pegasus [2] https://github.com/apache/arrow/tree/main/cpp [3] https://github.com/apache/kvrocks