Upgrade bundled jetty to 9.2.16.v20160414

[Alexander Leshkin]

Is there any interest in updating bundled in sdk jetty (current version 9.2.14)?

I can create PR if so.

[Thomas Broyer]

Is 9.2.16 API-compatible with 9.2.14? What does 9.2.16 bring to the table?
(BTW, if using Maven artifacts, you can easily upgrade without rebuilding)

[Alexander Leshkin]

воскресенье, 8 мая 2016 г., 10:47:36 UTC+3 пользователь Thomas Broyer написал:

Is 9.2.16 API-compatible with 9.2.14?

Unfortunately I don't have much experience with 9.2.x backward compatibility. But jetty 9.2.16 from custom GWT SDK build works well in our GWT applications.

 

What does 9.2.16 bring to the table?

Mostly bug fixes. Not much new API.

My personal interest is a GzipHandler API changes. 

I'm faced with problem with bundled jetty's version (9.2.14) and spring-boot (1.3.3.RELEASE) gzip handler setup (spring-boot uses GzipHandler API that has been extended in 9.2.15).

Of course, this is true only for launching from IDE (eclipse).

I can live with this by unbundling jetty from SDK version of gwt-dev, but may be it is worth to update bundled jetty to the latest version before beta/RC/release. 

(BTW, if using Maven artifacts, you can easily upgrade without rebuilding)

Yes, and this works fine when building production. But, as I said above, developers have some problems when launching application from eclipse with GWT plugin.

I know, that client and server side is not recommended to mix in the same project. But, I think it is very convenient if you can mix client and server side in some cases. 

[Thomas Broyer]

Not sure I understand your concern: Jetty is no longer bundled in gwt-dev in 2.8.0-SNAPSHOT (Maven artifacts only)

[Alexander Leshkin]

воскресенье, 8 мая 2016 г., 23:07:37 UTC+3 пользователь Thomas Broyer написал:

Not sure I understand your concern: Jetty is no longer bundled in gwt-dev in 2.8.0-SNAPSHOT (Maven artifacts only)

I mean gwt-dev from SDK which is used in eclipse plugin.

[Thomas Broyer]

Eclipse plugin will use Maven dependencies if you use Maven (I suppose that won't be the case if you use Gradle or Ivy though).

There are alternatives too:

• put Jetty 9.2.15+ ahead of gwt-dev in the runtime classpath to shadow the bundled classes
• don't add GWT SDK library from GPE, dismiss the error that it's missing; if that disables the "run as… → web application", then just create a "java application" launcher "by hand".

If we were to update Jetty again, I suppose we'd rather jump to 9.3 than just a bugfix release.

Also, GPE can be fixed/updated to detect GWT from the build path and/or support Gradle builds, now that Eclipse comes with Buildship bundled.

[Alexander Leshkin]

OK, I understood. 

Thank you.

понедельник, 9 мая 2016 г., 11:29:06 UTC+3 пользователь Thomas Broyer написал: