Updating GWT CLDR data from v25 to v32

[Ahmad Bawaneh]

Dears

I have been working on updating the CLDR data from cldr version 25 to cldr version 32, the generation of the new data have been done successfully and all gwt test cases pass.

i would like to make a pull request for both the cldr tools and gwt but first i need to discuss the part related to the GoogleMods.patch

this patch was supposed to be version 25 which is too old now and since we are going to a new version of cldr data 32 Do we still need to fix and apply the patch, or should we go with a more standard cldr data?

i need to decide on this before i finish my work and make a pull request.

Thanks

[Ahmad Bawaneh]

Sorry i forgot to link my work to this issue

https://github.com/gwtproject/gwt/issues/9557

[Colin Alworth]

From our discussion in Gitter, it sounds like many/most of the changes in GoogleMods are no longer needed to get tests to pass - either the existing tests are insufficient to make sure that these changes are still there, or the important changes have been folded in upstream.

I do recall that there were large portions of the patch that no longer apply cleanly (not a huge surprise since it is 7 versions apart), either because the change is already there, or because that region of code changed, and the diff no longer makes sense.

Googlers: If these changes are important, can you weigh in on how we will evaluate the jar before it gets pushed to tools? If not, are we comfortable just using the standard CLDR 32 release, so we can fix the out-of-date timezones that currently plague GWT?

[Colin Alworth]

With no replies in two weeks, I'd say you should proceed with a change request to the tools repo to add the new jar, and the changes required to the gwt project itself to support the new version.

[Ahmad Bawaneh]

This is perfect, i will do my best to deliver the PR this weekend

[Ahmad Bawaneh]

The PR for the cldr tools landed on the repository, following that will make a PR for gwt update.
https://github.com/gwtproject/tools/pull/13

On Thursday, March 1, 2018 at 4:19:22 PM UTC+2, Colin Alworth wrote:

[Ahmad Bawaneh]

The update for the latest CLDR data is now on gerrit for review
https://gwt-review.googlesource.com/c/gwt/+/20600

On Friday, February 2, 2018 at 9:47:59 PM UTC+2, Ahmad Bawaneh wrote:

[Ahmad Bawaneh]

it looks like more cldr versions have been released since my last cldr update,  CLDR is now at version 34.
I have made two changes, updating the jar in the tools repo, and updating generated classes in gwt repo to make the new data available.
The gwt patch on gerrit is :

https://gwt-review.googlesource.com/c/gwt/+/21400

and the PR for the tools repo can be found here:

https://github.com/gwtproject/tools/pull/15

the github issue for this change can be found here 

https://github.com/gwtproject/gwt/issues/9557

for more information about CLDR please visit the cldr home page, you might also look into the release notes since gwt is upgrading from cldr version 25 which is an old release to the latest 34 cldr release

find the home page here

http://cldr.unicode.org/

Additionally gwt uses a very old version of ICU (more about ICU here), so I have prepared a follow-up patch which will update gwt ICU4J version to 63.1 from the current 50.1.1

the git hub issue for this change is here

https://github.com/gwtproject/gwt/issues/8703

On Friday, February 2, 2018 at 9:47:59 PM UTC+2, Ahmad Bawaneh wrote:

[Ahmad Bawaneh]

Hi

With the PR for the tools being already merged https://github.com/gwtproject/tools/pull/16

I am looking for review and approval on the gwt PR

https://gwt-review.googlesource.com/c/gwt/+/21421

Thanks.

On Friday, February 2, 2018 at 9:47:59 PM UTC+2, Ahmad Bawaneh wrote: