Change the superDevMode to be the default for dev-mode?

113 views
Skip to first unread message

Goktug Gokdogan

unread,
Sep 30, 2014, 2:55:01 PM9/30/14
to google-web-toolkit-contributors
Thinking about it, we should probably make superDevMode opt-out instead of opt-in and make it work out of the box for existing users instead of asking them to add the -superDevMode.

So what do you think about making superDevMode the default for dev-mode in 2.7 release?

PS: BTW, if you haven't already, take a look at the Daniel's video here:

John Stalcup

unread,
Sep 30, 2014, 2:57:56 PM9/30/14
to google-web-tool...@googlegroups.com
Yeah I kind of agree.

If DevMode support is removed in Chrome soon after the 2.7 release, we'll be wishing we'd made DevMode launches default to turning superDevMode on. 

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA2K2J_MBVVcwyFiBT54riyH_Wh_QL1ES0uXHP_YAn7yRg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Brandon Donnelson

unread,
Sep 30, 2014, 3:06:58 PM9/30/14
to google-web-tool...@googlegroups.com
I was looking at this when updating the feature for GPE and thought this might change in 3.0, but would be easy to adjust in GPE, I'm testing the preview build now and things are working good. 

But on the other hand if this changes, what do you think would happen, b/c I would need to deal with the change right away so I can change it in GPE and get IDEA to change the program arg. 

How do you see the flag getting changed?

On Tuesday, September 30, 2014 11:57:56 AM UTC-7, John Stalcup wrote:
Yeah I kind of agree.

If DevMode support is removed in Chrome soon after the 2.7 release, we'll be wishing we'd made DevMode launches default to turning superDevMode on. 
On Tue, Sep 30, 2014 at 11:54 AM, 'Goktug Gokdogan' via GWT Contributors <google-web-toolkit-contri...@googlegroups.com> wrote:
Thinking about it, we should probably make superDevMode opt-out instead of opt-in and make it work out of the box for existing users instead of asking them to add the -superDevMode.

So what do you think about making superDevMode the default for dev-mode in 2.7 release?

PS: BTW, if you haven't already, take a look at the Daniel's video here:

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscribe@googlegroups.com.

Goktug Gokdogan

unread,
Sep 30, 2014, 3:49:59 PM9/30/14
to google-web-toolkit-contributors
On Tue, Sep 30, 2014 at 12:06 PM, Brandon Donnelson <branfl...@gmail.com> wrote:
I was looking at this when updating the feature for GPE and thought this might change in 3.0, but would be easy to adjust in GPE, I'm testing the preview build now and things are working good. 


The only thing I care here is trying to avoid telling thousands of developer to pass a flag to get what we consider the recommended way. If we change the default then they will basically upgrade the SDK and reuse their existing configurations.

So that depends on how soon people get the GPE updates (I thought lots of people might just only upgrade the SDK?) and if there is going to be need for additional instructions (e.g. need to recreate run/debug configuration).

 
But on the other hand if this changes, what do you think would happen, b/c I would need to deal with the change right away so I can change it in GPE and get IDEA to change the program arg. 

How do you see the flag getting changed?


We would keep the flag the same but change the default.
So passing -superDevMode or nothing enables superdev mode and passing -nosuperDevMode disables the superdev mode.

 
On Tuesday, September 30, 2014 11:57:56 AM UTC-7, John Stalcup wrote:
Yeah I kind of agree.

If DevMode support is removed in Chrome soon after the 2.7 release, we'll be wishing we'd made DevMode launches default to turning superDevMode on. 

On Tue, Sep 30, 2014 at 11:54 AM, 'Goktug Gokdogan' via GWT Contributors <google-web-toolkit-contri...@googlegroups.com> wrote:
Thinking about it, we should probably make superDevMode opt-out instead of opt-in and make it work out of the box for existing users instead of asking them to add the -superDevMode.

So what do you think about making superDevMode the default for dev-mode in 2.7 release?

PS: BTW, if you haven't already, take a look at the Daniel's video here:

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA2K2J_MBVVcwyFiBT54riyH_Wh_QL1ES0uXHP_YAn7yRg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/b034b9b9-b349-463a-9186-e15d675235ed%40googlegroups.com.

Thomas Broyer

unread,
Sep 30, 2014, 6:40:15 PM9/30/14
to google-web-tool...@googlegroups.com
Fwiw, we made it the default in the gwt-maven-plugin.

Brandon Donnelson

unread,
Sep 30, 2014, 7:21:34 PM9/30/14
to google-web-tool...@googlegroups.com
Should I make this default behavior in GPE? On by default?
Screen Shot 2014-09-30 at 4.21.23 PM.png

Daniel Kurka

unread,
Sep 30, 2014, 7:22:24 PM9/30/14
to google-web-tool...@googlegroups.com
The GWT team thinks that this should be the default behaviour going forward.

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.



--
Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Katherine Stephens

John Stalcup

unread,
Sep 30, 2014, 7:28:18 PM9/30/14
to google-web-tool...@googlegroups.com
Goktug mentioned that he thinks the option should be on be default in GWT, which would mean no change necessary in GPE. And I agree.

On Tue, Sep 30, 2014 at 4:21 PM, Brandon Donnelson <branfl...@gmail.com> wrote:

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.

Brandon Donnelson

unread,
Sep 30, 2014, 7:28:21 PM9/30/14
to google-web-tool...@googlegroups.com
We've got quite a few downstream changes to fixup if the flag changes to turn on DevMode then. When do you think we can get that in so I can adjust GPE program args. :)


On Tuesday, September 30, 2014 4:22:24 PM UTC-7, Daniel Kurka wrote:
The GWT team thinks that this should be the default behaviour going forward.
On Tue, Sep 30, 2014 at 4:21 PM, Brandon Donnelson <branfl...@gmail.com> wrote:
Should I make this default behavior in GPE? On by default?

On Tuesday, September 30, 2014 3:40:15 PM UTC-7, Thomas Broyer wrote:
Fwiw, we made it the default in the gwt-maven-plugin.

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscribe@googlegroups.com.

Brandon Donnelson

unread,
Sep 30, 2014, 7:31:50 PM9/30/14
to google-web-tool...@googlegroups.com
Gotcha. Well, I baked in -superDevMode program arg switch, and this is also backported in an embedded jar. I would have to take into account some switch to turn back on DevMode. I was hoping to alleviate the pain of changing the program args by hand. 


On Tuesday, September 30, 2014 4:28:18 PM UTC-7, John Stalcup wrote:
Goktug mentioned that he thinks the option should be on be default in GWT, which would mean no change necessary in GPE. And I agree.
On Tue, Sep 30, 2014 at 4:21 PM, Brandon Donnelson <branfl...@gmail.com> wrote:
Should I make this default behavior in GPE? On by default?

On Tuesday, September 30, 2014 3:40:15 PM UTC-7, Thomas Broyer wrote:
Fwiw, we made it the default in the gwt-maven-plugin.

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscribe@googlegroups.com.

John Stalcup

unread,
Sep 30, 2014, 7:59:28 PM9/30/14
to google-web-tool...@googlegroups.com
Brandon and I talked a bit about if offline and just the summarize:

If we want to accomplish "making SuperDevMode on as the default behavior in the DevMode launcher in GPE" it is going to require some changes in Brandon's work regardless of whether we do it via updating the default value of the flag in GWT (because he'll need to start adding -nosuperDevMode when Classic DevMode is selected)  or instead update the default setting of the radio button in the GPE launcher.

So since it's the same amount of work either way, and since updating the default value of the flag in GWT has the advantage of having an effect for command line users as well, this option is preferable.


To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/cf5783b0-a94a-48b4-a92c-15c85e318e18%40googlegroups.com.

Brandon Donnelson

unread,
Oct 1, 2014, 7:09:17 PM10/1/14
to google-web-tool...@googlegroups.com
Just an update. I've contacted Jetbrains dev to add a flag to turn on DevMode with -nosuperDevMode and I'm finishing up the changes with GPE switches. 


On Tuesday, September 30, 2014 4:59:28 PM UTC-7, John Stalcup wrote:
Brandon and I talked a bit about if offline and just the summarize:

If we want to accomplish "making SuperDevMode on as the default behavior in the DevMode launcher in GPE" it is going to require some changes in Brandon's work regardless of whether we do it via updating the default value of the flag in GWT (because he'll need to start adding -nosuperDevMode when Classic DevMode is selected)  or instead update the default setting of the radio button in the GPE launcher.

So since it's the same amount of work either way, and since updating the default value of the flag in GWT has the advantage of having an effect for command line users as well, this option is preferable.

On Tue, Sep 30, 2014 at 4:31 PM, Brandon Donnelson <branfl...@gmail.com> wrote:
Gotcha. Well, I baked in -superDevMode program arg switch, and this is also backported in an embedded jar. I would have to take into account some switch to turn back on DevMode. I was hoping to alleviate the pain of changing the program args by hand. 

On Tuesday, September 30, 2014 4:28:18 PM UTC-7, John Stalcup wrote:
Goktug mentioned that he thinks the option should be on be default in GWT, which would mean no change necessary in GPE. And I agree.

On Tue, Sep 30, 2014 at 4:21 PM, Brandon Donnelson <branfl...@gmail.com> wrote:
Should I make this default behavior in GPE? On by default?

On Tuesday, September 30, 2014 3:40:15 PM UTC-7, Thomas Broyer wrote:
Fwiw, we made it the default in the gwt-maven-plugin.

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/bf5eda80-7c71-4daa-9e84-98521c108b69%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscribe@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages