[2.7.0-SNAPSHOT] Bug in compilation with pretty mode

147 views
Skip to first unread message

Julien Dramaix

unread,
Sep 26, 2014, 5:46:59 PM9/26/14
to google-web-tool...@googlegroups.com
Dear GWT lovers,

I've just tried to compile several projects with the last snapshot of GWT 2.7.0 using the PRETTY mode flag and several permutations. I noticed that only one js file (corresponding to one permutation) is emitted with non obfuscated javascript. The other files for each other permutation contains obfuscated javascript.

I've tested with GWT 2.6.1 and everything works as expected: all the files contain only non-obfuscated javascript.

Julien

Julien Dramaix

unread,
Oct 1, 2014, 5:27:13 PM10/1/14
to google-web-tool...@googlegroups.com
Am I the only one to have this problem ?

Roberto Lublinerman

unread,
Oct 1, 2014, 5:44:04 PM10/1/14
to google-web-tool...@googlegroups.com
Can you reproduce that from the command line in a regular compile? If so can you post all the flags passed to the compiler?

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CABb_3%3D4hPmdnqisA62R387c%3D77bVNboxB%3DW9R3%3DBgTFYTtvhNw%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

Manuel Carrasco Moñino

unread,
Oct 1, 2014, 5:44:22 PM10/1/14
to google-web-tool...@googlegroups.com
I could verify the issue.
A clue, It seems that the last emitted permutation is the only one un-obfuscated. 

As a workaround you can collapse-all-properties, and the result is PRETTY

- Manolo

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.

Manuel Carrasco Moñino

unread,
Oct 1, 2014, 5:49:13 PM10/1/14
to google-web-tool...@googlegroups.com
Roberto, in my case this is the command line:

/Library/Java/JavaVirtualMachines/jdk1.8.0_05.jdk/Contents/Home/jre/bin/java -Xmx512m -classpath . . .  -Dgwt.persistentunitcachedir= target com.google.gwt.dev.Compiler -logLevel INFO -style PRETTY -war target/v-demo-1.0-SNAPSHOT -localWorkers 8 -draftCompile -XnocheckCasts -compileReport -XfragmentCount -1 -sourceLevel 1.7 -XjsInteropMode NONE -extra target/extra -gen v-demo/target/.generated com.vaadin.prototype.wc.gwt.Demo

I'm compiling with maven using gwt-maven-2.7-SNAPSHOT and trunk GWT.




Colin Alworth

unread,
Oct 1, 2014, 6:50:38 PM10/1/14
to google-web-tool...@googlegroups.com
I also can reproduce this - when style is set to PRETTY, 4 of the 17 permutations starts off with the PRETTY setup code (from the linker?), then moves on to have all obfuscated (and sorted, etc) JS from the compilation process:

var $wnd = $wnd || window.parent;
var __gwtModuleFunction = $wnd.explorer;
var $sendStats = __gwtModuleFunction.__sendStats;
$sendStats('moduleStartup', 'moduleEvalStart');
var $gwt_version = "2.7.0-SNAPSHOT";
var $strongName = '1C1FC666B8D8D4A5634A1EDA3B51C36D';
var $gwt = {};
var $doc = $wnd.document;
var $moduleName, $moduleBase;
function __gwtStartLoadingFragment(frag) {
var fragFile = 'deferredjs/' + $strongName + '/' + frag + '.cache.js';
return __gwtModuleFunction.__startLoadingFragment(fragFile);
}
function __gwtInstallCode(code) {return __gwtModuleFunction.__installRunAsyncCode(code);}
function __gwt_isKnownPropertyValue(propName, propValue) {
return __gwtModuleFunction.__gwt_isKnownPropertyValue(propName, propValue);
}
function __gwt_getMetaProperty(name) {
return __gwtModuleFunction.__gwt_getMetaProperty(name);
}
var $stats = $wnd.__gwtStatsEvent ? function(a) {return $wnd.__gwtStatsEvent(a);} : null;
var $sessionId = $wnd.__gwtStatsSessionId ? $wnd.__gwtStatsSessionId : null;
function Qg(){}
function lr(){}
function fu(){}
function nu(){}
function Cu(){}...

file names, sizes:
23908346   0D4B0A8AEFAF8328F37ABFBECEB765AC.cache.js
23900780   102B4372CC1E48D4E25EF20E66AD58DC.cache.js
23900946   10F8674F5E5DA2F77E606EDC3EF15643.cache.js
23900106   19BE3EA887194EC666A99E7BF57466C9.cache.js
3179517   1C1FC666B8D8D4A5634A1EDA3B51C36D.cache.js
23900433   467DE13BCB709965841DEF1F6BFD4785.cache.js
23917825   52AE506F1022BBF96CD25D74BD321C21.cache.js
23907954   6D952B9399698247258186190F8E0C38.cache.js
23900411   BB376480C0E3F616DF9CC28CCF948D0B.cache.js
23900195   C603EC38E0BF3A20A865927C32E7F122.cache.js
3143293   C868922D674E3536B6E83AF9DC005B4C.cache.js
23900252   CFB5CC0D39830766B7CCC22F07FBDD98.cache.js
3129165   D60063CBD8120FF39347C97C3C38B770.cache.js
3225082   DDCA4900448CB91C57415D5B87D0F4A8.cache.js
23900007   E11B2F6059BED303323AE4942F78E157.cache.js
23910979   F8003A30DB63AC175E0F7C5D0DF1EEA5.cache.js
23900163   FD1978D213B1B1592E0DC19E4F7FC46B.cache.js

A quick read of the compilation-mappings doesn't show a lot in common as to why this might be happening - D60063 is theme=neptune, user.agent=ie9 while DDCA49 is theme=gray, user.agent=safari, 1C1FC is theme=gray, user.agent=gecko1_8, and C86892 is theme=gray, user.agent=ie8.

Compiled from gwt-maven-plugin 2.7.0-SNAPSHOT as well.


For more options, visit https://groups.google.com/d/optout.

Roberto Lublinerman

unread,
Oct 1, 2014, 7:23:36 PM10/1/14
to google-web-tool...@googlegroups.com
I'll look into it.


Manolo,
Do you know what is the "Building Unknown Task" that is showing in our jenkins instance?

Roberto Lublinerman

unread,
Oct 1, 2014, 10:15:27 PM10/1/14
to google-web-tool...@googlegroups.com
Fixed. Review at https://gwt-review.googlesource.com/#/c/9432.

The issue is only present with -localWorkers > 1 and all workers except the first would get incorrect options.

Manuel Carrasco Moñino

unread,
Oct 2, 2014, 1:25:44 AM10/2/14
to google-web-tool...@googlegroups.com
On Thu, Oct 2, 2014 at 1:23 AM, 'Roberto Lublinerman' via GWT Contributors <google-web-tool...@googlegroups.com> wrote:
I'll look into it.


Manolo,
Do you know what is the "Building Unknown Task" that is showing in our jenkins instance?

There is a hidden task in our server which is only accessible for authenticated users, I use it for manually building gwt against an specific commit. I launched this built to check that the broken test was fixed with John's commit https://gwt-review.googlesource.com/#/c/9400/ . Jenkins show it to indicate that a worker is busy.

 

 
Reply all
Reply to author
Forward
0 new messages