Need help with test case

[Rene Hangstrup Møller]

Hi

I am trying to write a test case for https://github.com/gwtproject/gwt/issues/7247

There was an old test in https://github.com/gwtproject/gwt/issues/7247#issue-87058425 that reproduces the problem.

I am trying to narrow it down and implement it as part of the existing SerializableTypeOracleBuilderTest instead, but so far I cannot make it fail (after removing the change to SerializableTypeOracleBuilder)

By adding tracing to the original test case that reproduced the problem I can see that computeTypeInstantiability() visits the classes in this order:

Level1, Root, Parameter, Level2, AnInterface

But in my new test case they are visited in this order:

Root, Level1, Level2, Parameter, AnInterface

My theory is that the test will fail if they are visited in the same order as in the original setup.

Any suggestions for either
- how I can force the classes to be visited in the desired order?
- how I can make the test closer to the original setup?

Best regards
Rene

[Rene Hangstrup Møller]

I would also like a tip on how to run that testcase alone.

Right now I am doing this:

(cd user && ant test -Dtest.emma.selenium.disable=true -Dtest.draft.htmlunit.disable=true -Dtest.coverage.htmlunit.disable=true -Dtest.nometa.htmlunit.disable=true -Dtest.nongwt.disable=true -Dtest.dev.htmlunit.disable=true -Dtest.web.htmlunit.disable=true -Dgwt.junit.testcase.includes=**/SerializableTypeOracleBuilderTest.class)

Can I narrow it further down

Best regards
Rene

[Rene Hangstrup Møller]

I am still a bit puzzled by the gerrit interface.

What is the correct way to add a comment to a patch set, or reply to a comment from a reviewer?

[Jens]

At the top is a "reply" button. When you enter text in the corresponding text box it is a general reply for the CL. You can also add comments for a file or for a line of source code. To do so navigate to the desired patch set (top right drop down) and open the file. At the top middle is a small icon which allows you to do a file based comment. Alternatively you can click any line number you want to comment in the file view or mark some code using the mouse and press "c". On both cases you have to click the small "save" button to save your comment as draft. To publish all your file/line comments you need to use the "reply" button at the top again (and you can still add a general comment as well in the reply box)

If you want to reply a specific general comment you can open that comment and click the small reply arrow on the very right side. For file/line based comments there is a small reply button in the yellow comment box in the file view.

Hope that helps.

-- J.

[Rene Hangstrup Møller]

Thank you, that helped a lot.

/Rene