Cannot build my project since 779627ac

[Honza Rameš]

Hello everyone,
recently, after updating GWT master I wasn't able to neither compile nor debug my project in DevMode. I tracked the problem down to commit 779627ac after which I'm getting errors (see bellow) while generating UiBinder glue to one of my widgets it complains one of my interfaces isn't a type, but its there on the class path. The interface is a ClientBundle that I use from within the UiBinder template to load image from. Weird think is that I have similar ClientBundle placed elsewhere and used in another UiBinder template which works OK. This is not a problem with not having some modules included in my gwt.xml, the project setup remained the same. The app I'm compiling (I tried eclipse compile/DevMode and running the compiler from command line by hand as well) is a multi-project setup having two separate eclipse projects used as sources, but it never posed a problem. I tried to revert the changes from 779627ac and compiled on top of current HEAD (f6d098fc) and the project compiles OK.

The UiBinder template usage is pretty standard:
...
<ui:with field='res' type='com.promis.ui.client.bundles.Images'/>
...
<g:Image resource="{res.information}"/>

public class SplashFrm extends DecoratedPopupPanel implements CenterHelper.Client
{
    private static SplashFrmUiBinder uiBinder = GWT.create(SplashFrmUiBinder.class);
    interface SplashFrmUiBinder extends UiBinder<Widget, SplashFrm> {}
...

During compile this produces following error log:
      Validating units:
         Errors in 'generated://5CF227F805D1F55776CDB49692D603C5/com/promis/weblink/client/ui/SplashFrm_SplashFrmUiBinderImpl.java'
            See snapshot: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\com.promis.weblink.client.ui.SplashFrm_SplashFrmUiBinderImpl77307997322787911.java
         Ignored 1 unit with compilation errors in first pass.
Compile with -strict or with -logLevel set to TRACE or DEBUG to see all errors.
   [ERROR] Errors in 'generated://5CF227F805D1F55776CDB49692D603C5/com/promis/weblink/client/ui/SplashFrm_SplashFrmUiBinderImpl.java'
      [ERROR] Line 15: com.promis.ui.client.bundles.Images cannot be resolved to a type
      [ERROR] Line 15: com.promis.ui.client.bundles.Images cannot be resolved to a type
      [ERROR] Line 15: com.promis.ui.client.bundles.Images cannot be resolved to a type
      See snapshot: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\com.promis.weblink.client.ui.SplashFrm_SplashFrmUiBinderImpl4533299510520776392.java
   [ERROR] Errors in 'com/promis/weblink/client/ui/SplashFrm.java'
      [ERROR] Line 17: Rebind result 'com.promis.weblink.client.ui.SplashFrm_SplashFrmUiBinderImpl' could not be found
   Adding '2' new generated units
      Validating units:
         Errors in 'generated://488AE7991663EA6C1F032A3C1B0EE609/com/promis/ui/client/bundles/Images_cs_InlineClientBundleGenerator.java'
            See snapshot: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\com.promis.ui.client.bundles.Images_cs_InlineClientBundleGenerator6947991448159430337.java
         Errors in 'generated://F74F74BA6B19A984D800E9A65EDA2E2B/com/promis/ui/client/bundles/Images_en_InlineClientBundleGenerator.java'
            See snapshot: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\com.promis.ui.client.bundles.Images_en_InlineClientBundleGenerator4281512586235817971.java
         Ignored 2 units with compilation errors in first pass.
Compile with -strict or with -logLevel set to TRACE or DEBUG to see all errors.
   [ERROR] Errors in 'generated://488AE7991663EA6C1F032A3C1B0EE609/com/promis/ui/client/bundles/Images_cs_InlineClientBundleGenerator.java'
      [ERROR] Line 136: Referencing class 'com.promis.ui.client.bundles.Images': unable to resolve class
      [ERROR] Line 137: Referencing class 'com.promis.ui.client.bundles.Images': unable to resolve class
      [ERROR] Line 138: Referencing class 'com.promis.ui.client.bundles.Images': unable to resolve class
      [ERROR] Line 139: Referencing class 'com.promis.ui.client.bundles.Images': unable to resolve class
      [ERROR] Line 140: Referencing class 'com.promis.ui.client.bundles.Images': unable to resolve class
      [ERROR] Line 6: com.promis.ui.client.bundles.Images cannot be resolved to a type
      See snapshot: C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\com.promis.ui.client.bundles.Images_cs_InlineClientBundleGenerator3324679282687144960.java
   [ERROR] Errors in 'com/promis/ui/client/bundles/Images.java'
      [ERROR] Line 9: Rebind result 'com.promis.ui.client.bundles.Images_cs_InlineClientBundleGenerator' could not be found

The generated files both use absolute names to the com.promis.ui.client.bundles.Images type.

If more complete information is needed I'll be happy to provide it.

Thanks for any help in this matter.

Honza R.

[Goktug Gokdogan]

[+stalcup]

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[John Stalcup]

reconstructing the failure chain:

com.promis.weblink.client.ui.SplashFrm.java // victim

  com.promis.weblink.client.ui.SplashFrm_SplashFrmUiBinderImpl // victim

    com.promis.ui.client.bundles.Images // victim

      com.promis.ui.client.bundles.Images_cs_InlineClientBundleGenerator // actually is missing

I believe your bundle failed to be created because of changes I made in that patch in https://gwt-review.googlesource.com/#/c/6552/2/user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java and corrected a week later in https://gwt-review.googlesource.com/#/c/6574/1/user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java .

Have you synced recently? I think your issue goes away as long as you are synced to at least 6d4d8a2.

On Sat, Mar 22, 2014 at 2:55 AM, Honza Rameš <ram...@gmail.com> wrote:

--

[Honza Rameš]

Thanks for the clarification. I'm usually syncing quite often but I had a two month pause after which I wasn't able to compile. I compiled GWT based on f6d098fc (which is one of the latest commits) and it stopped working so I began to search for the for the commit that produced this error. Last commit that works for me is fd0d1716. As I said I also tried to reverse merge changes from 779627ac on top of f6d098fc and it worked just fine. I must note that I have useLazyWidgetBuilders set to false. I needed this so some of my "fake" widgets that carry only informational data and are never attached are initialized properly.

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to a topic in the Google Groups "GWT Contributors" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit-contributors/xulD0U8LrAY/unsubscribe.
To unsubscribe from this group and all its topics, send an email to google-web-toolkit-co...@googlegroups.com.

[Honza Rameš]

Hello again,

I finally got the time to look in it in more detail. Problem is not the AbstractClientBundleGenerator but the JdtCompiler. It only occurs if resources are mixed with the sources that have the same name as the directory holding the images (misinterpreting it for package). I have Images.java client bundle interface that includes images from images sub-folder and the compiler (com.google.gwt.dev.javac.JdtCompiler.INameEnvironmentImpl.isPackage(String)) then thinks my/pkg/Images is a package but it is just a resource directory (renaming the directory solves the problem), but finding out the exact problem is rather difficult. If the images directory would indeed be a package it would fail also (I understand this would be rather weird but it may happen). This also probably only happen on windows (I do have images folder in lowercase and my type's first letter is uppercase).

I added getClassLoader().getResource(slashedPackageName + ".java") == null to the isPackage test which solves my issue (more complete testing may be needed but this solves my problem and I can use most recent sources :-) )

Regards

Honza

On Tuesday, March 25, 2014 8:41:42 AM UTC+1, Honza Rameš wrote:

Thanks for the clarification. I'm usually syncing quite often but I had a two month pause after which I wasn't able to compile. I compiled GWT based on f6d098fc (which is one of the latest commits) and it stopped working so I began to search for the for the commit that produced this error. Last commit that works for me is fd0d1716. As I said I also tried to reverse merge changes from 779627ac on top of f6d098fc and it worked just fine. I must note that I have useLazyWidgetBuilders set to false. I needed this so some of my "fake" widgets that carry only informational data and are never attached are initialized properly.

To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to a topic in the Google Groups "GWT Contributors" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit-contributors/xulD0U8LrAY/unsubscribe.

To unsubscribe from this group and all its topics, send an email to google-web-toolkit-contributors+unsubscribe@googlegroups.com.

[Thomas Broyer]

Jens actually stumbled on it too, and reported it: https://code.google.com/p/google-web-toolkit/issues/detail?id=8716