Random behaviour using the old js api library and the callback

[Xiao Lin Liu]

Hi all,

in the last week, we have found that some of our client production environments is showing a random behavior which stops showing the maps

We do this call 

https://www.google.com/jsapi?callback=MapUtil.googleLoaderCallback

Most of time it works fine but some times, we get an 302 error and the process is stopped.

I know this is the old library version and we are changing to use the new library but I do concern about existing versions.  I've been reading in the group and in theory there is still backward compatibility.

Also, I'd like to remark that after a couple of days all started working perfectly but now it looks like this has come back but I do not get a 302 error and the behaviour is again random.

Is there something that is happening?

Regards,

Xiao 

[Daniel LaLiberte]

Hi Xiao,

We have been gradually ramping up the redirect from the old jsapi loader to the new loader, and it is supposed to support the callback parameter as well, but apparently not in the same way.

After ramping up to 100% a couple weeks ago, we discovered an internal problem, and reverted the redirect to 0%.  And a couple days ago, we started ramping up again.

Is your MapUtil.googleLoaderCallback the name of your own function, or one that you expect to be loaded.  Can you point me to your web page so that I can see what is happening?  I am curious what is happening and if we might be able to fix it, since there might be many more users out there who are seeing the same issue but silently.

--
You received this message because you are subscribed to the Google Groups "Google Visualization API" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-visualizati...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/google-visualization-api/2f3b2dc4-9ca4-4fb8-8639-827da8db2ac2%40googlegroups.com.

--

Daniel LaLiberte

dlaliberte@Google.com   Cambridge MA

[Xiao Lin Liu]

Also, this is part of the code:

We only wait for the callback and then get the credentials to log in and define our style. but the callback is never invoked in the failed case

public static loadApi(callback: () => void = null): void {

        if (MapUtil.loaded) {

            callback();

        } else {

            var script = <HTMLScriptElement>document.createElement("script");

            script.src = "https://www.google.com/jsapi?callback=MapUtil.googleLoaderCallback";

            script.type = "text/javascript";

            document.getElementsByTagName("head")[0].appendChild(script);

            MapUtil.loadApiCallback = callback;

        }

    }

    public static googleLoaderCallback() {

        MapUtil.loaded = true;

        let credentials = window.sessionStorage.getItem("googleMapsApiCredentials");

        if (credentials === null || credentials === "") {

            KnockoutUtil.ajax({

                url: "/api/configurationapi/GetGoogleMapsAPICredentials",

                type: "GET",

                contentType: "application/json; charset=utf-8",

                dataType: "json",

                async: false,

                success: (data: string) => {

                    if (data !== null && data !== "") {

                        credentials = data;

                        window.sessionStorage.setItem("googleMapsApiCredentials", credentials);

                    }

                },

                error: () => {

                    throw new Error("Credentials could not be loaded")

                }

            })

        }

        let a: object;

            (<any>google).load("maps", "3", {

                "other_params": `client=${credentials}&sensor=false&channel=${client}&libraries=geometry,visualization,places,drawing `,

                "callback": () => {

                    MapUtil.impactMap = new google.maps.StyledMapType(MapUtil.MAP_IMPACT, { name: "Impact" });

                    MapUtil.loadApiCallback();

                    MapUtil.createPopupClass();

                }

            });

    }

[Daniel LaLiberte]

I see a potential cause of the problem. I don't quite follow your notation in the last part of the code (after let a: object), but I see:

"other_params": `client=${credentials}&sensor=false&channel=${client}&libraries=geometry,visualization,places,drawing `,

This would be a problem since the new loader is not yet handling the other_params parameter.  I am actually making a change to support it now, because it turns out this is the cause of some internal problems as well.

Also, this code makes me wonder:

            var script = <HTMLScriptElement>document.createElement("script");

            script.src = "https://www.google.com/jsapi?callback=MapUtil.googleLoaderCallback";

            script.type = "text/javascript";

            document.getElementsByTagName("head")[0].appendChild(script);

            MapUtil.loadApiCallback = callback;

Since you add the script tag that includes the callback=MapUtil.googleLoaderCallback, but I don't see where you have defined MapUtil.googleLoaderCallback, unless it is the definition of public static googleLoaderCallback(), which would have to be static methods of MapUtil.  

But since there are multiple callbacks in your code, I am not sure which callback you are referring to. I see:

if (MapUtil.loaded) { callback(); }

jsapi?callback=MapUtil.googleLoaderCallback

MapUtil.loadApiCallback = callback;

google.load(... {"callback": () => {}})

MapUtil.loadApiCallback();

 And are you saying the callback is not called at all, or that it fails for some reason when it is called?

--
You received this message because you are subscribed to the Google Groups "Google Visualization API" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-visualizati...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-visualization-api/1a2cc920-fdfb-4cc0-a5c6-154704c0e53d%40googlegroups.com.

[Xiao Lin Liu]

Hi Daniel,

Yes, you are right this is only a piece of the entire class. The method for loadApiCallback is sort of the Maputil, actually all this code is part of the Maputil class.

When the call is routed to the new loader, the callback is not called at all. Also, why sometimes does it route to the new loader and some time it does not? Have you got the chance to see the screenshot about the network traces?

The other parameters fix, have you got an idea when it will be deployed? But I'm not sure if this is the cause of the problem as the callback is apparently not reached, when it is redirected to the new loader.

I can send you more info directly to your account due to some sensitivity data restrictions.

Regards

Xiao

[Daniel LaLiberte]

The redirects of jsapi to the new loader are now holding at a rate of 50%, meaning that half the requests are redirected, and half are not.  This is the maximally unstable rate which does 3 things:

1. raise attention about the transition

2. allow you to see both before and after, 

3. and in case 'after' is broken, allow users to see a working 'before' state at least part of the time.

We expect to add support for other_params early Monday morning.  And we will then push the redirect rate up to 100% on Wednesday.

If we see enough complaints about the absence of the other_params support, we could rollback the redirects to 0% again.  So far, this round, I only know about your issue.

Speaking of which, I am still not clear on the order of all those callbacks in your code.  Perhaps you could make a list of which calls you expect to happen when, or what alternative pathways might occur.  Feel free to email me directly instead of posting here.

--
You received this message because you are subscribed to the Google Groups "Google Visualization API" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-visualizati...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-visualization-api/661089fd-948a-4795-a116-c06dad6e7970%40googlegroups.com.

[Xiao Lin Liu]

Hi Daniel,

I'm posting here the code to replicate the scenario with only 2 files, in case someone has spotted the same issue.

Did you have the chance to look at this and see if this will be solved by the fix deployed on Monday? Any idea, when it will be deployed on Monday?

the html page

<!DOCTYPE html>

<html>

<head>

  <title>Simple Map</title>

  <meta name="viewport" content="initial-scale=1.0">

  <meta charset="utf-8">

  <style>

    /* Always set the map height explicitly to define the size of the div

       * element that contains the map. */

    #map {

      height: 100%;

      width: 100%;

    }

    /* Optional: Makes the sample page fill the window. */

    html,

    body {

      height: 100%;

      margin: 0;

      padding: 0;

    }

  </style>

</head>

<body>

  <div style="display: flex;flex-direction: row;height: 100%;width: 100%;">

    <div id="map"></div>

  </div>

  <script src="mapUtil.js"></script>

  <script>

    function afterAll() {

      var uluru = {lat: -25.363, lng: 131.044};

                    this.newmap = new google.maps.Map(document.getElementById('map'), {

                        center: uluru,

                        zoom: 8

                      });

      console.log("Everything is loaded");

    }

    MapUtil.loadApi(afterAll);

  </script>

</body>

</html>

and the javascript file

var MapUtil = /** @class */ (function () {

    function MapUtil() {

    }

    MapUtil.loadApi = function (callback) {

        if (callback === void 0) { callback = null; }

        if (MapUtil.loaded) {

            callback();

        }

        else {

            var script = document.createElement("script");

            script.src = "https://www.google.com/jsapi?callback=MapUtil.googleLoaderCallback";

            script.type = "text/javascript";

            document.getElementsByTagName("head")[0].appendChild(script);

            MapUtil.loadApiCallback = callback;

        }

    };

    MapUtil.googleLoaderCallback = function () {

        MapUtil.loaded = true;

        var credentials = "PUTCREDENTIALSHERE";

        var client = "PUTCLIENTHERE";

        var a;

        google.load("maps", "3", {

            "other_params": "client=" + credentials + "&sensor=false&channel=" + client + "&libraries=geometry,visualization,places,drawing ",

            "callback": function () {

                MapUtil.loadApiCallback();

            }

        });

    };

    MapUtil.loaded = false;

    return MapUtil;

}());

Running and refreshing this page, we can see that sometimes the callback is completed and something is never reached.

Again, thanks for your help on this issue and I do apologize for disturbing with this but this issue is being critical on our product and we need to check all the options and how to solve it asap.

Regards

Xiao

[Daniel LaLiberte]

I've implemented the other_params setting when loading the 'maps' module.  So I would expect your use of other_params will be processed correctly, whereas it has been ignored so far (in the new loader).

I will be updating the loader very soon, for the update of Google Charts so that 'upcoming' will be version '48'.  This update will also support the other_params setting for 'maps', though not for any other modules (at this time).

--

You received this message because you are subscribed to the Google Groups "Google Visualization API" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-visualizati...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-visualization-api/6bdf6b07-cab1-46cc-9b01-278eb338b52e%40googlegroups.com.

[Xiao Lin Liu]

Thanks for the update, just let me know when it's update so I can test it on my side.

However, I'm concerned that the other_params is the actual root of our problem as in our case the callback is never trigger and the other_params is used just on the callback.

I don't think there is any other public endpoint with the new version which I can have a look in the meantime.

Regards,

Xiao 

[Daniel LaLiberte]

I just pushed out the new loader (for the v48 update) which supports the other_params.   Let me know if there are any issues.

--

You received this message because you are subscribed to the Google Groups "Google Visualization API" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-visualizati...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-visualization-api/a60510f0-ca31-428e-898b-5e868813309b%40googlegroups.com.

[Xiao Lin Liu]

I've just tested it and  it's still failing. When the redirect happens, the callback does not happen.

Does the rerouting works with callback  to internal methods?

Any further idea? is Wednesday the final rolled out date?

To view this discussion on the web visit https://groups.google.com/d/msgid/google-visualization-api/CAOtcSJOu6qtraRbL%2BaM9_5p%2BJqz2RE08yV2_FjBDCQ3%3DkW5KDg%40mail.gmail.com.

[Daniel LaLiberte]

The callback might be problematic if you are referencing it with a string name of the local function.   We are not doing an eval of the function, but looking it up as a global symbol. But if you can reference your callback function as a global string or as a function object, that ought to work.    I see you are passing a function object, so that ought to work.

Make sure you are not using a cached copy of the previous version of the loader.   I changed the caching headers for the loader over an hour ago, but sometimes browsers or caching servers will hold on to old versions longer than they should. 

To view this discussion on the web visit https://groups.google.com/d/msgid/google-visualization-api/CAKqh3by8scHje_AmdO74HHs4NRUvU8ucEpgiR1FMOtWF%2BiA03Q%40mail.gmail.com.

[Xiao Lin Liu]

I did refresh all and it is failing. I'll try again later.

Regarding the 100% rolled out date, is it still on Wednesday?. As I said, we are working on a fix on our side  but I want to know how much time we have to apply the fix to our clients.

Regards

Xiao  

To view this discussion on the web visit https://groups.google.com/d/msgid/google-visualization-api/CAOtcSJNBFidZMYnv3Gh28bh93tmWvnn2onFG7wJrU0jyXEWj9g%40mail.gmail.com.

[Xiao Lin Liu]

Also, I don't think you can defer the deployment because there is only one person with issues, can't you?

[Daniel LaLiberte]

The redirect of jsapi to the new loader is still planned to be 100% on Wednesday, yes.  I will be adding some tests of the callback to make sure it is doing what I believe it should be doing.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-visualization-api/CAKqh3bws%2Bb0OFM6-5ynJOoeWFiJw_RYjh_msB_y_wwcTMhX8oA%40mail.gmail.com.

[Daniel LaLiberte]

It is possible to defer, but we haven't heard of any other problems this time around, so you might be close to the last person with issues.

On Mon, Apr 27, 2020 at 1:41 PM Xiao Lin Liu <xiaol...@gmail.com> wrote:

Also, I don't think you can defer the deployment because there is only one person with issues, can't you?

--

You received this message because you are subscribed to the Google Groups "Google Visualization API" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-visualizati...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-visualization-api/ea77bfae-6254-48bf-880e-9f819f632dfb%40googlegroups.com.

[Xiao Lin Liu]

If you can check with the test code I did send you and let me know if you can spot the problem, that will be really helpful.

Again thanks for your invaluable help.

Xiao

[Xiao Lin Liu]

Just a naive question, Will it be possible to defer this a couple of days when it's only one company with problems.

I had escalate the problem to the Google maps support before reaching to this forum and unfortunately, I'm indirectly making you providing such support( I do apologize for that) as I could not get the root of the problem, now I'm much closer!

[Wolf Bergenheim]

Hello,

Yes, it might be possible to defer a little. How much time would you need? Would 1 week be meaningful for you?

Best Regards,

Wolf Bergenheim

Google Maps Support

[Xiao Lin Liu]

Hi Wolf,

if  this can be scheduled it will be great, this will give us time enough to promote our changes to the clients.

When will best suits you? Next Monday, Tuesday?

if you need the case number I raised with the support team, let me know and I'll be more than happy to provide it.

Regards,

Xiao 

--

You received this message because you are subscribed to the Google Groups "Google Visualization API" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-visualizati...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-visualization-api/3c203b13-ed4d-4b6a-96b1-e1f38e3bef3e%40googlegroups.com.

[Xiao Lin Liu]

Hi Wolf,

Monday is perfect for us so far. We are going to start sending the patches  to the client tomorrow and unless something changes, we should be ok to do that by Monday.

Anyway, I can provide an update on Friday.

For the case number

- 2303283: this was the original one

- 23225216: this was the one we escalate, in case we could contact directly to any support from this team.

Thanks again for all the help

Regards

Xiao 

El mar., 28 abr. 2020 a las 1:19, 'Wolf Bergenheim' via Google Visualization API (<google-visua...@googlegroups.com>) escribió:

Hi Xiao,

Please do share the case number, I can then look it up. And yes Monday Next week, if that will be sufficient time for you.

Let's check in on Friday what your status is, and preliminarily set the launch to Monday (morning) next week.

[Daniel LaLiberte]

By the way, I did do some additional tests of both the jsapi?callback=func and google.load(... {callback: func}, and both work for me.   You can also use google.setOnLoadCallback when loading 'maps'.   There is a possibility that combining the jsapi callback with the other mechanisms in the same document will cause some confusion, and this turns out to be difficult for me to test as well.  

It is possible that as soon as you use google.load or google.setOnLoadCallback, it will forget about the jsapi?callback=func.    But it shouldn't be necessary to use both at the same time, since either one should be able to do what you need.   So I would recommend trying to get rid of one or the other.

--
You received this message because you are subscribed to the Google Groups "Google Visualization API" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-visualizati...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-visualization-api/CAKqh3bxgV-Q8Dtuy3scAkB8XBubBJht%2B105yK-A%3DPO21UhRqqg%40mail.gmail.com.

[Xiao Lin Liu]

Hi, just let you know that we are ok for Monday deployment. Clients have taken our patch and Monday is perfect.

Again, thanks for all your help and flexibility.

Regards

Xiao

[Wolf Bergenheim]

Thank you for the update! Glad to hear it all worked out!

br,

Wolf Bergenheim

Google Maps Support

--
You received this message because you are subscribed to the Google Groups "Google Visualization API" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-visualizati...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-visualization-api/3ec052ae-6e41-414e-b429-3ff06fe0c13f%40googlegroups.com.

[Xiao Lin Liu]

Hi Wolf,

Once the roll out is completed today, Would you mind to let me know? Some clients wanted to know when the process is done.

A quick note in this thread, should be enough.

Regards

Xiao 

[Wolf Bergenheim]

Hi Xiao,

We have now fully rolled out the replacement. All requests are now hitting the new google visualization loader.

Best Regards,

Wolf Bergenheim

Google Maps Support

--
You received this message because you are subscribed to the Google Groups "Google Visualization API" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-visualizati...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-visualization-api/a6b92fca-41c8-40da-a30a-7ba53a553bb3%40googlegroups.com.