WebFont is not minified

112 visningar
Hoppa till det första olästa meddelandet

Dan Moore

oläst,
10 nov. 2019 18:55:202019-11-10
till Google AJAX APIs
For some reason, the minified file from the webfont repo is different than the version hosted by ajax.googleapis.com.

The ajax google hosted version contains an extra license at the top of it.

Any ideas why?


vs

Philipp Wollermann

oläst,
11 nov. 2019 04:56:012019-11-11
till Google AJAX APIs
Hi Dan,

that's a good question. Hosted Libraries aims to host exactly the same files as provided by upstream sources and it seems like this might not have happened here.

My guess at what happened is this:
We take great care at Google to correctly document the license and authorship of any third-party code. Sometimes this means that we have to add a license header in case the original files are missing one.
For Hosted Libraries we have an exception that we can serve unmodified copies of the original files, but maybe in this case the reviewer wasn't aware and a header was added by mistake.

I researched a bit about the extra license in that file. The Web Font Loader was co-developed by Typekit and Google.
Historically, Typekit was run by Small Batch Inc. which was acquired by Adobe in 2011 (https://blog.typekit.com/2011/10/03/adobe-acquires-typekit/), so this is just the old name in the copyright and not some other, unrelated company.
The license of Web Font Loader has been Apache 2.0 since the beginning (https://github.com/typekit/webfontloader/commits/master/LICENSE), so the extra header is just stating that fact again.

I hope this helps! Sorry for the confusion.

Kind regards,
Philipp

Dan Moore

oläst,
26 nov. 2019 15:01:152019-11-26
till Google AJAX APIs
Thanks for the reply Philipp.
I found this because that license is pretty big for a minified js file. We ended up hosting it ourselves since we were getting some warnings from Google Lighthouse on optimizing our production files for smaller sizes.

Just a heads up.
Best,
Dan
Svara alla
Svara författaren
Vidarebefordra
0 nya meddelanden