TODO comments in net/lookup_windows.go

[John Dreystadt]

Being a newbie to Go, I spent some time reading some of the standard packages and noticed a large number of TODO comments in lookup_windows.go. So I decided to see if I could resolve these comments. I now have a  working proof of concept for lookupIP standalone and maybe I should be working to contribute these changes. But I don't see any issues associated with these TODO comments. Should I create one or more issues or has a decision been made to not address these comments?

[Ian Lance Taylor]

On Wed, Mar 30, 2022 at 12:00 PM John Dreystadt <jdrey...@gmail.com> wrote:
>
> Being a newbie to Go, I spent some time reading some of the standard packages and noticed a large number of TODO comments in lookup_windows.go. So I decided to see if I could resolve these comments. I now have a working proof of concept for lookupIP standalone and maybe I should be working to contribute these changes. But I don't see any issues associated with these TODO comments. Should I create one or more issues or has a decision been made to not address these comments?

We don't in general require an issue to be filed for a change. If the
change is desirable you can just send a patch (see
https://go.dev/doc/contribute) without there being an open issue.
Thanks.

It looks the TODO comments are about extending the context plumbing so
that if the context is canceled or times out the functions/methods
will return quickly with the appropriate error. That seems like a
good thing to do in general, though I don't know specifically what
would have to change.

Ian