Go code owners: what are primary and secondary owners?

[M Hickford]

https://dev.golang.org/owners list primary and secondary owners, but doesn't explain what this means. What do primaries and secondaries do?

[Ian Lance Taylor]

On Wed, Nov 9, 2022 at 11:28 AM M Hickford <mirth.h...@gmail.com> wrote:
>
> https://dev.golang.org/owners list primary and secondary owners, but doesn't explain what this means. What do primaries and secondaries do?

It's pretty informal. For most packages primary owners are people who
take responsibility for the future direction of the package, including
any major changes. Secondary owners are people who are familiar with
the package and are willing to review bug fixes. But there are no
strict rules or even guidelines.

It's mostly used to add reviewers to incoming Gerritt changes.

Ian

[M Hickford]

Thanks. Does it affect who can approve a change? Or can any Go
maintainer approve any change in any path?
https://go.dev/doc/contribute#votes

[M Hickford]

Presumably all primaries and secondaries are Go maintainers?

[Ian Lance Taylor]

At present any maintainer (anybody with +2 rights) can approve any
change in any path.

In https://go.dev/issue/53383 we raised the possibility of some people
only having +2 rights over certain files (those that are specific to a
GOOS and/or GOARCH) but that has not been implemented.

Ian

[Ian Lance Taylor]

On Wed, Nov 9, 2022 at 2:15 PM M Hickford <mirth.h...@gmail.com> wrote:
>
> Presumably all primaries and secondaries are Go maintainers?

Probably? I haven't checked, though.

Ian