help wanted re windows syscall.Open() change

[Liam]

We need a CL for a minor GOOS=windows change; it has Go team clearance. (I would gladly, but cannot sign a CLA.)

Code change description

   https://github.com/golang/go/issues/32088#issuecomment-528141123

Docs change description

  https://github.com/golang/go/issues/32088#issuecomment-528142974

This should land soon, so there's time for any issues to surface prior to freeze.

[Constantin Konstantinidis]

CL is posted. The test added is from the issue which still failed on tip.

[Liam Breck]

What is the error you see, and what line is it from?

In the issue I suggested testing os.Rename() since that can be verified before the file is closed. 

I think this CL should also include the docs fix I referenced.

On Wed, Sep 11, 2019, 11:32 PM Constantin Konstantinidis <constantinko...@gmail.com> wrote:

CL is posted. The test added is from the issue which still failed on tip.

--
You received this message because you are subscribed to a topic in the Google Groups "golang-dev" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/golang-dev/YBzZiZlsEQM/unsubscribe.
To unsubscribe from this group and all its topics, send an email to golang-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/golang-dev/a90b541a-24ce-454f-93c6-389bdea0c8b6%40googlegroups.com.

[Constantin Konstantinidis]

 

 

Constantin KONSTANTINIDIS
Mob : +32485760683
http://be.linkedin.com/in/CostaKonstantinidis

 

From: Constantin Konstantinidis
Sent: jeudi 12 septembre 2019 08:56
To: Liam Breck
Subject: RE: [golang-dev] Re: help wanted re windows syscall.Open() change

 

Regarding the test, the error mentioned in the issue is still reproduced on tip and goes away with the CL.

A second test could be added.

 

The usual reviewer for Windows is pinged. I suggest to wait.

In another CL, changing syscall package was rejected. I had to fix it differently. Since a Windows update occured, it might go through this time.

 

Regarding documentation, I don’t know where this must be updated.

 

Constantin KONSTANTINIDIS
Mob : +32485760683
http://be.linkedin.com/in/CostaKonstantinidis

[Constantin Konstantinidis]

As suspected, there is no plan to proceed with this change (-2 now). Another solution than updating syscall package must be identified.

[Liam Breck]

The issue was recently marked release-blocker by Ian when I requested that it land early in 1.14 cycle...

On Thu, Sep 12, 2019, 3:07 AM Constantin Konstantinidis <constantinko...@gmail.com> wrote:

As suspected, there is no plan to proceed with this change (-2 now). Another solution than updating syscall package must be identified.

--

You received this message because you are subscribed to a topic in the Google Groups "golang-dev" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/golang-dev/YBzZiZlsEQM/unsubscribe.
To unsubscribe from this group and all its topics, send an email to golang-dev+...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/golang-dev/585f260d-8102-4206-bbea-9ce0b169674a%40googlegroups.com.

[Ian Lance Taylor]

On Thu, Sep 12, 2019 at 3:07 AM Constantin Konstantinidis
<constantinko...@gmail.com> wrote:
>
> As suspected, there is no plan to proceed with this change (-2 now). Another solution than updating syscall package must be identified.

That isn't what Alex's -2 meant. He meant: we need to first decide
what to do with the issue, and we must be sure to not commit the
change until that is done. That doesn't mean that we can't change the
syscall package. It means that we have to decide on the issue what we
should do.

Ian