Pipelines created through UI cannot reference pipelines through config repo as Upstream Pipeline

[Tina Boyce]

I came across an interesting behaviour and I was wondering if this is already known or expected, or is it a bug?

I've created 3 pipelines:

• child (through UI)
• parent (in my git repo, imported by config repo setting)
• parent-mkII (through UI)

I then went into the "child" pipeline setting > Materials > Add Material and in the Upstream Stage drop-down, the only given options was "parent-mkII"

This is not an isolated incident and what prompted me to start investigating was when I brought down gocd server a few times when I used the gocd api to deploy pipelines where the request body config referenced a pipeline that was deployed through the config repo.

The server error message was very similar every time, it was "Error: Pipeline 'from-config-repo' does not exist. It is used from pipeline 'from-api'.". However, it works fine if a pipeline is from the config repo referencing another pipeline from config repo.

[Chad Wilson]

Hiya Tina

I believe it is intentional that you cannot (normally) reference a config repo pipeline from a manually created pipeline (that otherwise sits in the config.xml).

https://github.com/gocd/gocd/issues/10667 has some discussion/explanation of this, along with https://github.com/gocd/gocd/issues/1133#issuecomment-109785886 and https://github.com/gocd/gocd/issues/1133#issue-77045258

However it sounds like an oversight or bug that the API is allowing you to do this (and take down the server). I do not know if that is intentional, but I suspect now - and really the API should be consistent with the UI in matters of "safety" such as this. Would probably be worthwhile raising an issue to investigate the inconsistency and try and fix the API validation if at all possible.

-Chad

--
You received this message because you are subscribed to the Google Groups "go-cd" group.
To unsubscribe from this group and stop receiving emails from it, send an email to go-cd+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/go-cd/8c35ce75-e0e4-4532-82d3-10d40ba303a3n%40googlegroups.com.

[Aravind SV]

Yes, you're right Chad. That is not intentional. I suspect the API is using the "merged" config to do its validation, instead of using the representation of the config XML. It is an oversight / bug.

Cheers,

Aravind

To view this discussion on the web visit https://groups.google.com/d/msgid/go-cd/CAA1RwH96yQ1q7ES_pXSXRnayg2QxdovGZUNm_eSaPJs8ySmshA%40mail.gmail.com.

[Tina Boyce]

Thank you Chad and Aravind for the quick helpful response.

I'll look into the API pipeline referencing a config repo pipeline further, get it easily reproduced and then raise the issue with the findings.

To view this discussion on the web visit https://groups.google.com/d/msgid/go-cd/CACxychHYXRV2iG4DpqAk2gQhsXdf4ZpESo-7PB3aqNoxfwHzUQ%40mail.gmail.com.

[Tina Boyce]

Created issue: https://github.com/gocd/gocd/issues/13003