src/input/draw2dSF.data is removed by "make clean"

3 views
Skip to first unread message

Qian Yun

unread,
Sep 23, 2023, 8:29:30 PM9/23/23
to fricas-devel
Commit "Clean results of Aldor test"
e149f276447bc3dcd22c563d74d7384e2238d876
removes "*.data" under src/input.

So after "make clean", that file is gone, and it will
clutter the result of "git diff".

Shall we tweak the Makefile or tweak the test data filename?

- Qian

Waldek Hebisch

unread,
Sep 24, 2023, 8:00:51 AM9/24/23
to fricas...@googlegroups.com
On Sun, Sep 24, 2023 at 08:29:26AM +0800, Qian Yun wrote:
> Commit "Clean results of Aldor test"
> e149f276447bc3dcd22c563d74d7384e2238d876
> removes "*.data" under src/input.
>
> So after "make clean", that file is gone, and it will
> clutter the result of "git diff".

I see, thanks for noticing this.

> Shall we tweak the Makefile or tweak the test data filename?

I think we should change data filename. Extention .data is
used by clisp and we should clean those files. Changing name
to 'draw2dSF.pts' looks easier and 'pts' is more informative
than generic 'data'.

--
Waldek Hebisch

Ralf Hemmecke

unread,
Sep 24, 2023, 8:52:57 AM9/24/23
to fricas...@googlegroups.com
Actually, I am not aware that the ending .data has anything to do with
an aldor test. Am I wrong? So the removal of *.data in that commit looks
wrong to me.

I have nothing against renaming .data to .pts. However, it would be good
to document somewhere what pts means. I have no idea.

Ralf

Waldek Hebisch

unread,
Sep 24, 2023, 9:44:41 AM9/24/23
to fricas...@googlegroups.com
On Sun, Sep 24, 2023 at 02:52:54PM +0200, Ralf Hemmecke wrote:
> Actually, I am not aware that the ending .data has anything to do with an
> aldor test. Am I wrong?

Yes. As I wrote, if you use clisp you will get trash .data
files. I am not sure if Aldor interface works with clisp, but
if you get to testing stage Aldor compilation will invoke
clisp compilation and produce .data file.

> So the removal of *.data in that commit looks wrong
> to me.

--
Waldek Hebisch

Qian Yun

unread,
Sep 24, 2023, 7:57:17 PM9/24/23
to fricas...@googlegroups.com
Change the suffix to "pts" or "txt"? It's your call and please
make the changes.

- Qian
Reply all
Reply to author
Forward
0 new messages