build_helper

0 views
Skip to first unread message

Ralf Hemmecke

unread,
Jul 9, 2023, 5:32:30 PM7/9/23
to fricas-devel
I guess build_helper (for whatever it is used) will no longer work,
since Waldek has renamed EXIT-WITH-STATUS to |exit_with_status|.

Ralf

Waldek Hebisch

unread,
Jul 9, 2023, 6:04:25 PM7/9/23
to fricas...@googlegroups.com
On Sun, Jul 09, 2023 at 11:32:27PM +0200, Ralf Hemmecke wrote:
> I guess build_helper (for whatever it is used) will no longer work, since
> Waldek has renamed EXIT-WITH-STATUS to |exit_with_status|.

Well, when it works then it works. Only when there is a compile
failure inline Lisp code will call EXIT-WITH-STATUS and fail.

Of course, we should fix this. Probably best is to have new
function in FRICAS-LISP that calls exit when compilation
fails.

--
Waldek Hebisch

Waldek Hebisch

unread,
Jul 11, 2023, 7:04:08 PM7/11/23
to fricas...@googlegroups.com
On Sun, Jul 09, 2023 at 11:32:27PM +0200, Ralf Hemmecke wrote:
> I guess build_helper (for whatever it is used) will no longer work, since
> Waldek has renamed EXIT-WITH-STATUS to |exit_with_status|.

AFAICS this problem is very easy to fix. Real problem is that
branch with exit is normally not taken. Namely, when there is
serious error, then Lisp compiler activates Lisp debugger.

OTOH we do not expect errors in generated Lisp code. In fact,
we do not expect errors in hand-written Lisp code too: such
code should be tested before running full build.

--
Waldek Hebisch
Reply all
Reply to author
Forward
0 new messages