turn IntegerLocalizedAtPrime into an OrderedRing

Ralf Hemmecke

unread,

Jun 21, 2022, 5:34:45 AM6/21/22

to fricas-devel

I've just realized that IntegerLocalizedAtPrime was not yet an
OrderedRing (no Comparable) and could therefore not be used as argument
to Expression.

Furthermore, I realized that hashUpdate! was not implemented.

Can this still go into the new release?

Ralf

Ralf Hemmecke

unread,

Jun 21, 2022, 5:38:21 AM6/21/22

to fricas...@googlegroups.com

Oh... see pull request:

https://github.com/fricas/fricas/pull/97

Waldek Hebisch

unread,

Jun 21, 2022, 11:41:27 AM6/21/22

to fricas...@googlegroups.com

Sorry, too late.

--
Waldek Hebisch

Ralf Hemmecke

unread,

Jun 21, 2022, 2:40:19 PM6/21/22

to fricas...@googlegroups.com

Well, it's a simple patch that doesn't affect anything else.

Ralf

Waldek Hebisch

unread,

Jun 21, 2022, 3:34:55 PM6/21/22

to fricas...@googlegroups.com

On Tue, Jun 21, 2022 at 08:40:15PM +0200, Ralf Hemmecke wrote:
> Well, it's a simple patch that doesn't affect anything else.

I was in the middle of creating release tarballs, any addition
at this point would mean restarting.

--
Waldek Hebisch

Waldek Hebisch

unread,

Jun 22, 2022, 1:05:24 PM6/22/22

to fricas...@googlegroups.com

On Tue, Jun 21, 2022 at 11:38:19AM +0200, Ralf Hemmecke wrote:
> Oh... see pull request:
>
> https://github.com/fricas/fricas/pull/97

And of course, it can go in now.

--
Waldek Hebisch

Reply all

Reply to author

Forward