$inclAssertions

5 views
Skip to first unread message

Ralf Hemmecke

unread,
Jul 28, 2020, 6:29:21 AM7/28/20
to fricas-devel
I realized that the variable is needed in jfricas.

But there seem to be assertions predefined that do not make sense anymore.

https://github.com/fricas/fricas/blob/master/src/interp/int-top.boot#L150

$inclAssertions: local := ["AIX", "CommonLisp"] -- Jan 28/90

Neither AIX nor CommonLisp are otherwise used in FriCAS code. Thus we
could as well set $inclAssertions to NIL.

Comments?

Ralf

Waldek Hebisch

unread,
Jul 28, 2020, 8:03:32 AM7/28/20
to fricas...@googlegroups.com
I am not sure what you mean by "is needed in jfricas". The
intent of this variable should be clear: it collects current
assertions used when reading files. In particular you can do
conditional compilations based on assertions. Built in
assertions allows making distinctions based on implementation
features. Corrently we do not use built in assertions, but
they are here if we need them in the future. "AIX" does not
make much sense, it did not bother me too much, but if you
are confused we may remove it. "CommonLisp" is sensible.

BTW: I keep (or kept) some thing as-is simply because then from
the history it is clear that code is old and may need update to
changed reality. Partial changes may suggest that code is
up to date leading to confusion.
--
Waldek Hebisch

Ralf Hemmecke

unread,
Jul 28, 2020, 8:40:25 AM7/28/20
to fricas-devel
> I am not sure what you mean by "is needed in jfricas".

I have not yet included it in jfricas 1.0.0, but without initializing
it, the command ")compile foo.spad" leads to problems. But this is
another issue and I will deal with that later, because that part of
jfricas would actually be a candidate for being included into FriCAS. I
will propose a pull-request if it is time.

> BTW: I keep (or kept) some thing as-is simply because then from the
> history it is clear that code is old and may need update to changed
> reality. Partial changes may suggest that code is up to date leading
> to confusion.

No need to remove the "AIX" label. I just wanted to state that there is
useless code.

And whether some part of the code is old or new can nowadays easily
figured out via "git blame FILENME.spad".

Ralf

Reply all
Reply to author
Forward
0 new messages