YSlow 3.1.4 is broken with Firebug 1.12

[Sebastian Zartner]

This was previously mentioned in another thread.

On Tuesday, August 20, 2013 11:56:14 AM UTC+2, Leho Kraav wrote:

On Tuesday, August 20, 2013 11:49:38 AM UTC+3, Sebastian Zartner wrote:

Works fine for me using FF 23.0.1/26.0a1 + FB 1.12b7 + YS 3.1.4 on Win7.
What do you mean by "does not work"? Do you see any related errors in the Error Console (Ctrl+Shift+J)? Please disable any other extensions you have installed and try it again. Does it work then?

Means the same as in the original problem report above. Clicking on YSlow UI buttons does nothing.

As of yesterday, latest available was 1.12b6. Not sure where you got b7 from?

From getfirebug.com, though it seems it was removed again. Honza, did you do that?

Anyway, I tried out the final version of 1.12 available on addons.mozilla.org on another PC now and now I can see the bug, too. There are also two error messages displayed in the Error Console:

Error: TypeError: document.ysview is undefined
Source: resource://firebugui/panel.html
Line: 1

Error: TypeError: document.ysview is undefined
Source: javascript:document.ysview.showComponents()
Line: 1

It's still working in 1.11.4. So I assume it is related to the move of panel.html to the resource:// protocol.
Honza, Simon, any idea?

Sebastian

[Leho Kraav]

It's still working in 1.11.4. So I assume it is related to the move of panel.html to the resource:// protocol.
Honza, Simon, any idea?

Yep, I'm confirming that YSlow works fine on 1.11 series.

[Jan Honza Odvarko]

On Tuesday, August 20, 2013 5:48:34 PM UTC+2, Sebastian Zartner wrote:

As of yesterday, latest available was 1.12b6. Not sure where you got b7 from?

From getfirebug.com, though it seems it was removed again. Honza, did you do that?

Firebug 1.12.0 beta 7 wasn't released yet.
(but the tag exists in the repo, so someone could do a private build)

Honza

[Sebastian Zartner]

As of yesterday, latest available was 1.12b6. Not sure where you got b7 from?

From getfirebug.com, though it seems it was removed again. Honza, did you do that?

Firebug 1.12.0 beta 7 wasn't released yet.

(but the tag exists in the repo, so someone could do a private build)

Then I probably accidentally downloaded alpha 7. At least I didn't build beta 7 by myself.

Obviously Steven already created a report in the YSlow issue tracker for this.

Sebastian

[Jan Honza Odvarko]

Update:

YSlow 3.1.7 fixing compatibility issues with Firebug 1.12 has been released and is available here:
https://addons.mozilla.org/en-US/firefox/addon/yslow/versions/?page=1#version-3.1.7

Please let us know if it's working for you now.

Honza

[Mike Sheehan]

The tabs and links across the top of YSlow 3.1.7 are fixed for Firebug 1.12.0, but the left-side tabs on the Grade page still don't work.

Mike

[Jan Honza Odvarko]

On Friday, August 23, 2013 1:55:03 AM UTC+2, Mike Sheehan wrote:

The tabs and links across the top of YSlow 3.1.7 are fixed for Firebug 1.12.0, but the left-side tabs on the Grade page still don't work.

What exactly should I do to see the problem on my machine?

Honza

[Leho Kraav]

On 23.08.2013 10:40, Jan Honza Odvarko wrote:
>
>
> On Friday, August 23, 2013 1:55:03 AM UTC+2, Mike Sheehan wrote:
>
> The tabs and links across the top of YSlow 3.1.7 are fixed for

> Firebug 1.12.0, but the left-side tabs on the *Grade *page still

> don't work.
>
> What exactly should I do to see the problem on my machine?
>

I'm confirming Mike is correct, it is broken.

Just Run Test for any website and then try to click the individual item
breakdown tabs in the YSlow result screen left sidebar.

[Jan Honza Odvarko]

On Friday, August 23, 2013 9:59:41 AM UTC+2, Leho Kraav wrote:

I'm confirming Mike is correct, it is broken.

Just Run Test for any website and then try to click the individual item
breakdown tabs in the YSlow result screen left sidebar.

OK, I see it now. Reported here:
https://github.com/marcelduran/yslow/issues/84

Should be easy to fix (I'll provide a patch).

Honza

[Jan Honza Odvarko]

OK, I have created a patch fixing the problem
Now, waiting for merge and release.

But, you can build the new yslow xpi yourself if you
don't want to wait (let me know if you need any
help with that).

Honza