Can I create patch for recurring sales order? Any suggestion?

[Sambhaji Kolate]

Hi guys,

 I am creating recurring sales order and recurring sales invoice. Can I create patch for this and apply this into other system?

Thanks,

Sambhaji

[Sambhaji Kolate]

sorry, 

Can I create patch for recurring purchase order? Any suggestion?

--
Note:
 
If you are posting an issue,
 
1. ERPNext is a free and open source software and support is given on this forum by a team (https://frappe.io/webnotes). So please consider donating if you find this forum useful (https://frappe.io/buy). Even a small amount would be helpful.
2. We should be able to replicate it at our end. So please give us as much information as you can. Please see it from the point of view of the person receiving the communication.
3. Paste your code at http://pastebin.com or http://gist.github.com and send only the URL via email
4. For sending images, use http://imgur.com or other similar services. Do not send images as attachments. Links are good. Same goes for any file you are going to send.
 
End of Note
---
You received this message because you are subscribed to a topic in the Google Groups "ERPNext Developer Forum" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/erpnext-developer-forum/0z1VknZc2Dc/unsubscribe.
To unsubscribe from this group and all its topics, send an email to erpnext-developer...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-developer-forum/a67d7cd6-db14-482f-b384-d13d7d738dee%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Nabin Hait]

Can you give a brief about the purpose / use-case of recurring Purchase Order? We can add the option in the product too.

You received this message because you are subscribed to the Google Groups "ERPNext Developer Forum" group.
To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-developer...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-developer-forum/CADH2dyh8u7ouVT6sf5nOTA09jnpdYZd18rBm6etvmjxYq_7vYA%40mail.gmail.com.

[Sambhaji Kolate]

Hi Nabin,

Recurring Purchase Orders/Invoices would be typically used to set-up recurring bills for vendors (like Utilities - Water, Electricity, Warehouse Rent, Location Rent etc) which need to be paid monthly/quarterly/yearly etc.

Please correct me if I'm wrong but this feature is currently not available in ERPNext but a Recurring Sales Order/Invoice is available.

Would be really great if we could add this to the application.

Regards

Sambhaji 

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-developer-forum/323FB282-4960-48B5-B9F1-70B8CBF05144%40gmail.com.

[Nabin Hait]

Thanks. Please add this in github issue list.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-developer-forum/CADH2dyj4%2B%2BzjVobxx6H0ixgozZa0kt_BN1UJTy38MgAo-FarbA%40mail.gmail.com.

[Rushabh Mehta]

Check this:

https://github.com/frappe/erpnext/pull/2109

You will have to add the relevant fields to Purchase Order and update the recurring generator to include Purchase Orders

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-developer-forum/CADH2dyj4%2B%2BzjVobxx6H0ixgozZa0kt_BN1UJTy38MgAo-FarbA%40mail.gmail.com.

[Sambhaji Kolate]

Thanks for giving link, I will start working and send pull request. 

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-developer-forum/57443E3C-FFDE-4905-A8D7-8C0B2BB76450%40gmail.com.

[Sambhaji Kolate]

Hi all,

I have made couple of code changes for recurring PO/PI referring the pull request below.

I want to send a new pull request for review but had a query - how should I include my UI/Form changes in this pull request? My changes are present in my local box but I could not see any UI specific files getting changed (*.json) which I can commit back to my fork.

Regards
Sambhaji

[Rushabh Mehta]

You should see changes in your json files. Did you set developer_mode=1 in your site_config.json

@rushabh_mehta

via mobile

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-developer-forum/CADH2dyhd1D3ZWS_-Ka14bvqNSf1H2MUQbuorz47XvAGZU06WuA%40mail.gmail.com.

[Sambhaji Kolate]

I set developer_mode=1 in your site_config.json. I can also customize form but I didn't see any changes in json files

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-developer-forum/1684FCFA-1082-43D1-8B78-40EFAA279DDE%40gmail.com.

[Rushabh Mehta]

On 09-Sep-2014, at 9:23 pm, Sambhaji Kolate <kolate....@gmail.com> wrote:

I set developer_mode=1 in your site_config.json. I can also customize form but I didn't see any changes in json files

Change in DocType - don't use Customize Form - Customize Form is for local customization - not product.

best,

Rushabh

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-developer-forum/CADH2dyiNoG8COQxHYEjuXc6VYgx7xKd1kJadLZkMu1Rg_EB64w%40mail.gmail.com.

[Sambhaji Kolate]

Hi Rushabh,

Thanks for the response. I was able to make these changes locally and test.

I've sent a pull request - https://github.com/frappe/erpnext/pull/2171. Could you please review?

Also, I've not created a GitHub issue for this, will that be required?

Regards

Sambhaji

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-developer-forum/CDA4D1FE-58F9-45D8-B153-20F7E79D12F1%40gmail.com.

[Rushabh Mehta]

Sambhaji,

Thanks! Your tests are failing - do fix them. @anand will review your changes. You will also have to write test cases for PO / PI to test if recurring works fine.

https://travis-ci.org/frappe/erpnext/builds/34890115

best,

Rushabh

@rushabh_mehta

https://erpnext.org

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-developer-forum/CADH2dyjhJRzFca8xcETjx_X7Pue%2BiM_MCmcEerwX9c5j0-ejLw%40mail.gmail.com.

[Sambhaji Kolate]

I have fixed the changes for recurring PO/PI along with test cases. Please review changes.
If there is any improvement or changes then let me know.

https://github.com/frappe/erpnext/pull/2186/files

Thanks in advance

Sambhaji
Systematrix Solutions

[JorgeH]

Hello Everyone


I am looking at the code for the first time..

I have  a question, please correct me if I am wrong.

It seems to me that you are using javascript for business logic as well as for the presentation logic.


Wouldn't it be better (or at least neater) to use js strictly for user interface related logic and python for business logic?


Thanks

[Rushabh Mehta]

On 15-Sep-2014, at 8:23 pm, JorgeH <jorg...@gmail.com> wrote:

Hello Everyone


I am looking at the code for the first time..

I have  a question, please correct me if I am wrong.

It seems to me that you are using javascript for business logic as well as for the presentation logic.


Wouldn't it be better (or at least neater) to use js strictly for user interface related logic and python for business logic?

In most cases, the business login is on both server-side and client side. JS is to ensure instant feedback for the user.

Thanks




On Monday, September 15, 2014 4:13:09 AM UTC-5, Sambhaji Kolate wrote:

I have fixed the changes for recurring PO/PI along with test cases. Please review changes.
If there is any improvement or changes then let me know.

https://github.com/frappe/erpnext/pull/2186/files

Thanks in advance

Sambhaji
Systematrix Solutions

--
Note:
 
If you are posting an issue,
 
1. ERPNext is a free and open source software and support is given on this forum by a team (https://frappe.io/webnotes). So please consider donating if you find this forum useful (https://frappe.io/buy). Even a small amount would be helpful.
2. We should be able to replicate it at our end. So please give us as much information as you can. Please see it from the point of view of the person receiving the communication.
3. Paste your code at http://pastebin.com or http://gist.github.com and send only the URL via email
4. For sending images, use http://imgur.com or other similar services. Do not send images as attachments. Links are good. Same goes for any file you are going to send.
 
End of Note
---
You received this message because you are subscribed to the Google Groups "ERPNext Developer Forum" group.
To unsubscribe from this group and stop receiving emails from it, send an email to erpnext-developer...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/erpnext-developer-forum/983e15e3-4b08-4781-b4ee-034676b3e075%40googlegroups.com.