Pull requests?

44 views
Skip to first unread message

Martin Kleinschrodt

unread,
Apr 16, 2014, 9:45:26 AM4/16/14
to enyo-dev...@googlegroups.com
Is anyone still checking the pull requests on github? I've submitted an one-line fix about two weeks ago and haven't gotten any reaction yet. Here's the pull request: https://github.com/enyojs/enyo/pull/698

John McConnell

unread,
Apr 16, 2014, 11:43:12 AM4/16/14
to enyo-dev...@googlegroups.com
The Ares team has also been side track too. Been gone ( just checking in once and a while)  for about a month. I will bet there off on a  secret mission. I hear that new webos TV being played with do not have a store yet  http://forums.webosnation.com/webos-tv/327738-lg-webos-tv-got-one.html But that just my wild ADHD mind playing with me :)
john




On 4/16/2014 9:45 AM, Martin Kleinschrodt wrote:
Is anyone still checking the pull requests on github? I've submitted an one-line fix about two weeks ago and haven't gotten any reaction yet. Here's the pull request: https://github.com/enyojs/enyo/pull/698
--
You received this message because you are subscribed to the Google Groups "Enyo Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to enyo-developme...@googlegroups.com.
To post to this group, send email to enyo-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/enyo-development/aec5c4ad-22a6-4795-9b43-353afb808627%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.




This email is free from viruses and malware because avast! Antivirus protection is active.


Ken Corbett

unread,
Apr 16, 2014, 4:39:15 PM4/16/14
to enyo-dev...@googlegroups.com
Yea it would be nice to know what is going on.  I also have a relatively simple pull request that has just been sitting for a couple of weeks.  I think we are already missing Ben.

Johann Jacobsohn

unread,
Apr 16, 2014, 4:43:47 PM4/16/14
to enyo-dev...@googlegroups.com
Me too, and I've been wondering the same.
> <https://github.com/enyojs/enyo/pull/698>
>
> --
> You received this message because you are subscribed to the Google
> Groups "Enyo Development" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to enyo-developme...@googlegroups.com
> <mailto:enyo-developme...@googlegroups.com>.
> To post to this group, send email to enyo-dev...@googlegroups.com
> <mailto:enyo-dev...@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/enyo-development/f872ba38-7700-44fe-b87c-24b11aa5dfd0%40googlegroups.com
> <https://groups.google.com/d/msgid/enyo-development/f872ba38-7700-44fe-b87c-24b11aa5dfd0%40googlegroups.com?utm_medium=email&utm_source=footer>.
> For more options, visit https://groups.google.com/d/optout.


--

Martin Kleinschrodt

unread,
Apr 16, 2014, 4:47:20 PM4/16/14
to enyo-dev...@googlegroups.com
Well, good to know I'm not alone at least...


On Wednesday, April 16, 2014 10:43:47 PM UTC+2, Johann Jacobsohn wrote:
Me too, and I've been wondering the same.

On 16.04.2014 22:39, Ken Corbett wrote:
> Yea it would be nice to know what is going on.  I also have a
> relatively simple pull request that has just been sitting for a couple
> of weeks.  I think we are already missing Ben.
>
>
>
> On Wednesday, April 16, 2014 6:45:26 AM UTC-7, Martin Kleinschrodt wrote:
>
>     Is anyone still checking the pull requests on github? I've
>     submitted an one-line fix about two weeks ago and haven't gotten
>     any reaction yet. Here's the pull
>     request: https://github.com/enyojs/enyo/pull/698
>     <https://github.com/enyojs/enyo/pull/698>
>
> --
> You received this message because you are subscribed to the Google
> Groups "Enyo Development" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to enyo-developme...@googlegroups.com

Kevin Schaaf

unread,
Apr 16, 2014, 7:02:48 PM4/16/14
to enyo-dev...@googlegroups.com
Hi all,

We are indeed a little taxed at the moment, both with finally getting 2.4 tagged & released earlier this week and with several people out on spring vacations— but we’re here and well!  We’ll try and evaluate and merge/comment on these PR's in short order.

On the Enyo core side, we’re currently working on getting the relational data-layer work that Cole’s been working on over the past couple months merged into mater, along with a sweeping comment syntax update.  We are targeting 2.5 to switch Enyo documentation over to JSDoc 3, which will provide a path to providing much better API docs and an integrated doc viewer that doesn’t rely on realtime code analysis (which is why the current API viewer is so slow to load).  More to come on that.

Since both of the changes above require touching virtually all files in Enyo core, we’re going to be merging new PR’s into a "2.4.1-pre” branch until we get the big changes merged to master, and then we’ll do a one-time hand merge of any changes queued on 2.4.1-pre back into master once that’s done (and in the interim, if we need to make a release before 2.5, we’ll make it off of the 2.4.1 branch).  So, for the short-term we’ll ask anyone making PR’s to enyo core to please make them to the 2.4.1-pre branch for the time being.

Thanks,

Kevin

To unsubscribe from this group and stop receiving emails from it, send an email to enyo-developme...@googlegroups.com.
To post to this group, send email to enyo-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/enyo-development/0bb0c5bd-796f-46a6-8d1e-b14faa7aaf26%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages