PSA: emcc.py's run method is now split into several functions/phases.
17 views
Skip to first unread message
Sam Clegg
unread,
Apr 26, 2021, 8:41:43 PM4/26/21
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to emscripte...@googlegroups.com
My apologies to anyone with outstanding changes to emcc.py. Mostly like this change (https://github.com/emscripten-core/emscripten/pull/13998) will make merging/rebasing very hard since it moves so many lines of code around. I'm struggling to rebase all of my many changes on top of it now and it's not fun(!), but I do think in the long run it's going to make working on this file much easier.
cheers,
sam
Sam Clegg
unread,
May 10, 2021, 3:28:29 PM5/10/21
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
Again, if you have changes to these parts of emcc.py in outstanding PRs, this may cause conflict (although way less likely than with #13998). I will hold off landing this change if anyone has outstanding changes they would like to land first?