Added 64-bit file support to emscripten

31 views
Skip to first unread message

Joshua Minter

unread,
Jun 6, 2019, 9:33:33 PM6/6/19
to emscripten-discuss
We were removing a bunch of custom changes in Emscripten and noticed that out of all of them, 64-bit file support (in particular llseek) still isn't supported in Emscripten, even though we aren't the only ones that want this feature (eg. #5250). So we have upstreamed this to a PR for Emscripten at #8759.

Notably, we added an extra setting called LARGE_FILESYSTEM which when enabled will allow for seeks larger than the 2^32 limit. Due to still using JavaScript doubles, however, it still has a hard 2^53 limit to prevent weird errors to do with double accuracy. No other places were found that required changes for this support and nothing was found in the documents specifically specifying a 32-bit limit, however a test case has been added.

 We hope that you accept these changes into the main repo :)

Alon Zakai

unread,
Jun 7, 2019, 1:44:48 PM6/7/19
to emscripte...@googlegroups.com
Thanks for the PR!

- Alon

--
You received this message because you are subscribed to the Google Groups "emscripten-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to emscripten-disc...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/emscripten-discuss/d9052920-1579-490e-a2da-7f176c27c295%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply all
Reply to author
Forward
0 new messages