Proposal: URI.merge/2

[Andrew Timberlake]

Example:

iex> URI.merge("http://example.com/foo", "/bar") |> to_string
"http://example.com/bar"

iex> URI.parse("http://example.com/foo") |> URI.merge("/bar") |> to_string
"http://example.com/bar"

…and more

I have written the code based on RFC2396 §5.2 and would like to send through a pull request.

Andrew

[Onorio Catenacci]

Not that it seems any different in a salient way but it looks like 2396 was superseded by RFC 3986.  I looked at it quickly but didn't see any significant differences but you may just want to double check your implementation to insure it conforms.

--

Onorio

[Jon Parise]

A minor piece of feedback, but have you considered naming this URI.join/2?

That would be consistent with similar functions in Python (urlparse.urljoin) and Ruby (URI.join).

Andrew

--
You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-co...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/C1FD35C2-B4C6-4701-83AC-F0F1FA656E1D%40andrewtimberlake.com.
For more options, visit https://groups.google.com/d/optout.

[Andrew Timberlake]

Thanks for pointing that out, I’ll have a look.

Andrew

--
You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-co...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/860a3ca4-0972-4e4d-8796-3f953937637d%40googlegroups.com.

[Andrew Timberlake]

Jon

RFC3986 refers to the process as merging in §5.2

“The pseudocode above refers to a "merge" routine for merging a

   relative-path reference with the path of the base URI”

But, I’m indifferent about the naming.

Andrew

To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAPdFhdVX1inBx8TV7Q32rDLYetiydfHXk1isBRWn_GkL2erXhA%40mail.gmail.com.

[Andrew Timberlake]

I’ve made changes picked up from RFC3986 and submitted a pull request, https://github.com/elixir-lang/elixir/pull/4644

Andrew

[Peter Hamilton]

What's missing from Path.join?

iex(1)> Path.join("http://google.com", "/bar")

"http://google.com/bar"

iex(2)> Path.join("http://google.com/", "/bar")

"http://google.com/bar"

iex(3)> Path.join("http://google.com/foo", "/bar")

"http://google.com/foo/bar"

iex(4)> Path.join("http://google.com/foo", "bar")

"http://google.com/foo/bar"

If something, the new function should definitely be URI.join

To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/4AADBC83-0BBB-40DC-A69E-5B09CF32ABB4%40andrewtimberlake.com.

[Andrew Timberlake]

Just some example differences.

iex> Path.join("http://google.com", "http://example.com")

"http://google.com/http://example.com"

iex> URI.merge("http://google.com", "http://example.com") |> to_string

"http://example.com"

iex> Path.join("http://google.com?a=b", "?x=y")

"http://google.com?a=b/?x=y"

iex> URI.merge("http://google.com?a=b", "?x=y") |> to_string

"http://google.com?x=y"

There is an active pull request, please add some comments there if you still have some.

https://github.com/elixir-lang/elixir/pull/4644

Andrew

To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAOMhEnzjo23afXNYZ0ZviJYBmaxMSgJef%3DEsBoXGyq5SFikuPg%40mail.gmail.com.

[Onorio Catenacci]

You should look at the RFC he references Peter.  The rules for merging URI's are not quite as straightforward as you would guess.  Looking at the samples in the RFC, it looks like Andrew's gotten his code right and it looks like Path.join would not serve the need.

--

Onorio

--
You received this message because you are subscribed to a topic in the Google Groups "elixir-lang-core" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/elixir-lang-core/d4oY2p1wFbk/unsubscribe.
To unsubscribe from this group and all its topics, send an email to elixir-lang-co...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAOMhEnzjo23afXNYZ0ZviJYBmaxMSgJef%3DEsBoXGyq5SFikuPg%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

Onorio Catenacci
 
http://onor.io

http://www.google.com/+OnorioCatenacci

[Peter Hamilton]

I see.

merge is a better name than join, since it clearly does something quite different.

To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAP%3DvNq8Jwb1KQwBxbUgpgV%3D9yJPMvBpmX%3DFpG7HN6dyRqpjRKA%40mail.gmail.com.