[PATCH] ci: Address travis-ci findings in config file

5 views
Skip to first unread message

Jan Kiszka

unread,
Jul 6, 2021, 1:47:07 AM7/6/21
to efibootguard-dev
From: Jan Kiszka <jan.k...@siemens.com>

All harmless warnings, no functional changes.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>
---
.travis.yml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 9cf215f..6b48ac6 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -13,17 +13,16 @@
#

env:
- matrix:
+ jobs:
- TARGET=native
- TARGET=i586
- TARGET=cppcheck
language: c
+dist: xenial

compiler:
- gcc

-sudo: required
-
before_install:
- sudo apt-get update
- if [ $TRAVIS_BRANCH = coverity_scan ] && [ ${TRAVIS_JOB_NUMBER##*.} != 1 ]; then exit 0; fi
--
2.26.2

Cedric Hombourger

unread,
Jul 6, 2021, 2:00:30 AM7/6/21
to efibootg...@googlegroups.com

On 7/6/2021 7:47 AM, Jan Kiszka wrote:
> From: Jan Kiszka <jan.k...@siemens.com>
>
> All harmless warnings, no functional changes.

While warnings are harmless, the commit log should IMO summarize what we
are fixing

(e.g. "kill warning about distro not being specified and being therefore
assumed to be xenial")

Jan Kiszka

unread,
Jul 6, 2021, 2:33:37 AM7/6/21
to efibootguard-dev, Cedric Hombourger
From: Jan Kiszka <jan.k...@siemens.com>

All harmless warnings, no functional changes: sudo is now always on,
env:matrix became env:jobs, default dist is xenial.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>
---

Changes in v2:
- elaborate on what was found [Cedric]

.travis.yml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 9cf215f..6b48ac6 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -13,17 +13,16 @@
#

env:
- matrix:
+ jobs:
- TARGET=native
- TARGET=i586
- TARGET=cppcheck
language: c
+dist: xenial

compiler:
- gcc

-sudo: required
-
before_install:
- sudo apt-get update
- if [ $TRAVIS_BRANCH = coverity_scan ] && [ ${TRAVIS_JOB_NUMBER##*.} != 1 ]; then exit 0; fi
--
2.26.2

Cedric Hombourger

unread,
Jul 6, 2021, 2:48:37 AM7/6/21
to Jan Kiszka, efibootguard-dev

On 7/6/2021 8:33 AM, Jan Kiszka wrote:
> From: Jan Kiszka <jan.k...@siemens.com>
>
> All harmless warnings, no functional changes: sudo is now always on,
> env:matrix became env:jobs, default dist is xenial.
Looks good to me.
Reply all
Reply to author
Forward
0 new messages