[PATCH] COMPILE.md: added build tools

6 views
Skip to first unread message

Michael Adler

unread,
Nov 10, 2021, 8:24:46 AM11/10/21
to efibootg...@googlegroups.com, Michael Adler
These build tools are missing in minimal environments such as containers.
By adding them to COMPILE.md, it is easier to build efibootguard.

Signed-off-by: Michael Adler <michae...@siemens.com>
---
docs/COMPILE.md | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/docs/COMPILE.md b/docs/COMPILE.md
index efe30c1..39e5ae0 100644
--- a/docs/COMPILE.md
+++ b/docs/COMPILE.md
@@ -5,7 +5,11 @@
### Arch Linux ###

```
+# libs
pacman -S gnu-efi-libs pciutils check
+
+# build tools
+pacman -S gcc make automake autoconf libtool pkg-config
```

### Debian ###
@@ -13,7 +17,11 @@ pacman -S gnu-efi-libs pciutils check
Debian 8 or newer:

```
+# libs
apt-get install gnu-efi libpci-dev check
+
+# build tools
+apt-get install make automake autoconf libtool pkg-config
```

## Compilation ##
--
2.33.1

Jan Kiszka

unread,
Nov 10, 2021, 8:57:32 AM11/10/21
to Michael Adler, efibootg...@googlegroups.com
Thanks, applied.

How about test dependencies?

Jan

--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

Michael Adler

unread,
Nov 10, 2021, 9:16:56 AM11/10/21
to efibootg...@googlegroups.com, Michael Adler
These build tools are missing in minimal environments such as containers.
By adding them to COMPILE.md, it is easier to build efibootguard.

Signed-off-by: Michael Adler <michae...@siemens.com>
---
docs/COMPILE.md | 22 +++++++++++++++++-----
1 file changed, 17 insertions(+), 5 deletions(-)

diff --git a/docs/COMPILE.md b/docs/COMPILE.md
index efe30c1..d2fbaf2 100644
--- a/docs/COMPILE.md
+++ b/docs/COMPILE.md
@@ -5,7 +5,14 @@
### Arch Linux ###

```
-pacman -S gnu-efi-libs pciutils check
+# libs
+pacman -S gnu-efi-libs pciutils
+
+# build tools
+pacman -S gcc make automake autoconf libtool pkg-config
+
+# test dependencies
+pacman -S check bash-bats
```

### Debian ###
@@ -13,7 +20,14 @@ pacman -S gnu-efi-libs pciutils check
Debian 8 or newer:

```
-apt-get install gnu-efi libpci-dev check
+# libs
+apt-get install gnu-efi libpci-dev
+
+# build tools
+apt-get install make automake autoconf libtool pkg-config
+
+# test dependencies
+apt-get install check bats
```

## Compilation ##
@@ -51,6 +65,4 @@ where `<sys-root-dir>` points to the wanted sysroot for cross-compilation.
## Testing ##

* `make check` will run all unit tests.
-* `bats tests` will run all integration tests (you need
- [bats-core](https://github.com/bats-core/bats-core) for that; packaged as
- `bash-bats` for Arch Linux and `bats` for Debian).
+* `bats tests` will run all integration tests.
--
2.33.1

Michael Adler

unread,
Nov 10, 2021, 9:17:01 AM11/10/21
to Jan Kiszka, efibootg...@googlegroups.com
> How about test dependencies?

Good point, I have amended my patch (v2) in case you want to force-push onto next.

--
Michael Adler

Siemens AG
T RDA IOT SES-DE
Otto-Hahn-Ring 6
81739 München, Deutschland

Siemens Aktiengesellschaft: Vorsitzender des Aufsichtsrats: Jim Hagemann Snabe; Vorstand: Roland Busch, Vorsitzender; Klaus Helmrich, Cedrik Neike, Matthias Rebellius, Ralf P. Thomas, Judith Wiese; Sitz der Gesellschaft: Berlin und München, Deutschland; Registergericht: Berlin-Charlottenburg, HRB 12300, München, HRB 6684; WEEE-Reg.-Nr. DE 23691322

Jan Kiszka

unread,
Nov 10, 2021, 9:26:48 AM11/10/21
to Michael Adler, efibootg...@googlegroups.com
Thanks, replaced v1 in next with this one.
Reply all
Reply to author
Forward
0 new messages