[PATCH] main: Clean up PCI_GET_*_ID macros

3 views
Skip to first unread message

Jan Kiszka

unread,
Mar 4, 2022, 3:21:52 PM3/4/22
to efibootguard-dev
From: Jan Kiszka <jan.k...@siemens.com>

Properly type-casting their results to 16-bit improves readability. No
functional change, all consumers already did this type-cast implicitly.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>
---
main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/main.c b/main.c
index b11c5fb..68e4eff 100644
--- a/main.c
+++ b/main.c
@@ -27,8 +27,8 @@ extern const unsigned long init_array_start[];
extern const unsigned long init_array_end[];
extern CHAR16 *boot_medium_path;

-#define PCI_GET_VENDOR_ID(id) id
-#define PCI_GET_PRODUCT_ID(id) id >> 16
+#define PCI_GET_VENDOR_ID(id) (UINT16)(id)
+#define PCI_GET_PRODUCT_ID(id) (UINT16)((id) >> 16)

static EFI_STATUS probe_watchdogs(EFI_LOADED_IMAGE *loaded_image, UINTN timeout)
{
--
2.34.1
Reply all
Reply to author
Forward
0 new messages