Issue in shoppingcart module

[Ibo Sy]

Hey, I found an issue in the shoppingcart module and was wondering, is this still being maintained despite the e-commerce module? If yes, should the issue be reported through JIRA as CRI? Is anyone even still using this module?

Cheers,

Ibo

[David Ormsbee]

The shoppingcart app has been formally deprecated since Dogwood. I'm not on the Learner team, so I don't know what the schedule is for final removal of the code. But I'm honestly kind of surprised it's still around, and I wouldn't count on it living past Hawthorn.

What are you using it for, if you don't mind my asking?

Thank you.

Dave

--
You received this message because you are subscribed to the Google Groups "General Open edX discussion" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/edx-code/89e1ca99-4d21-465e-80b0-e52dcf65e7d6%40googlegroups.com.

[Ibo Sy]

Thank you for the info. Well the module is still working and easy to setup, so I was looking to use it for it's intended purpose - but I guess the recommendation is then to switch to the Oscar e-commerce module.

Regards,

Ibo

[mr...@teltek.es]

We are still using the ShoppingCart as well in production. Last year a simple PR on this module was accepted. We will keep using it as long as it is available. When it disappears, we will have to change to e-commerce. We've tried it out in Ficus, but haven't properly configured, that's why we keep using the ShoppingCart module.

If you know the solution for the issue, maybe you can try a Pull Request on GitHub. Maybe the Open edX team will consider your PR.

What is the issue about if I may ask?

[Ibo Sy]

Thank you, I will consider this.

The issue I found affects Coupon codes. If you apply a coupon code with an expiration date (which is a bit of an added feature anyway, as you can only set them through the sales_admin dashboard), the expiration date is only checked when added to the cart, but not on checkout. As the cart is saved, a user can apply a coupon code today which expires tomorrow, and finish the checkout a week later. A validation for all applied coupons on the processor can fix this.

[mr...@teltek.es]

We don't use the coupons, but as you describe it, it seems it may have an easy solution. I encourage you to try a PR on GitHub .