Ginkgo OAuth2 Identity Doc Outdated and Wierd "Provider slug" Effect

41 views
Skip to first unread message

jo...@zettageeks.com

unread,
Nov 29, 2017, 9:48:39 AM11/29/17
to General Open edX discussion
I'm working to set up a 3rd party Oauth2 identity provider authentication on a Native Ginkgo Devstack and separately on a Docker-hosted latest master. To begin, I've been following http://edx.readthedocs.io/projects/edx-installing-configuring-and-running/en/latest/configuration/tpa/tpa_integrate_open/tpa_oauth.html to set up the standard Google OAuth2 activation.

1) The documentation is outdated in the way it references https://github.com/omab/python-social-auth. This product has been deprecated, and the edX code has been moved to use the current https://github.com/python-social-auth/social-core package that has a (slightly) different path structure

2) After following the documentation - the Google standard auth option would not appear on the login / register. By chance, I found a comment in the platform's code "Fill in the provider_slug to be the same as backend_name for backwards compatability". Once I changed the Provider slug on the Django Admin form from an arbitrary string (as per the suggestion on the screen) to "google-auth2", I got a second configuration record created - and two Google icons showing on the login / register forms (one blue and one red).

Questions to the group:
(1) Is the master / Ginkgo code being actively updated as it relates to 3rd party OAuth2? Is the "provider slug" glitch just a fluke, or is there something I need to be aware of as I'm trying to put my custom configuration in?
(2) Is there a way to "delete" one of the configuration records in Django Admin - I don't need two Google icons
(3) Can the documentation be cleaned up to reflect the code and the exact necessary setup steps


jo...@zettageeks.com

unread,
Dec 1, 2017, 2:32:53 AM12/1/17
to General Open edX discussion
I think the real issue is the "Visible" checkmark. "If this option is not selected, users will not be presented with the provider as an option to authenticate with on the login screen, but manual authentication using the correct link is still possible."

By default, this option is unchecked. As it's not mentioned in the documentation (like most other options on the screen) - I initially skipped over it.

It's hard to comprehend why this option would even be provided, I mean to allow some "manual authentication using the correct link", when a 3rd party OAuth pretty much means to everyone having a button on the screen that says "Login with Google" (is the idea behind the option is to build a custom "Login with Google" button?) ... but anyway. The documentation is in a bad need of fixing - tell the people to check the "visible" option!


Reply all
Reply to author
Forward
0 new messages