Pocket milling (dev help)

[San Zamoyski]

Hi and hello everyone!

I'm happy to introduce dxf2gcode with pocket milling support. This work is inspired by thehammertownhead work [https://sourceforge.net/p/dxf2gcode/tickets/67/], but rewritten almost completely.

My goal was to create something that works, not necessarily efficient. I think I made it. It can be downloaded here: https://github.com/SanZamoyski/dxf2gcode-pocketMill/tree/Beta (remember to download Beta branch). 

There are some things that still need to be done, but I think that someone can find it useful and test it somehow for me.

Current TODO list can be found on Github:

dxf2gcode-pocketMill-Beta$ grep -Hrn '#TODO:' ./
./dxf2gcode/gui/canvas2d.py:41:                 #TODO: check if can be removed:
./dxf2gcode/gui/canvas.py:31:                   #TODO: check if can be removed:
./dxf2gcode/core/pocketmill.py:56:              #TODO: remove everywhere: self.stmove.shape.OffsetXY
./dxf2gcode/core/pocketmill.py:364:             #TODO: check if shape like this:
./dxf2gcode/core/pocketmill.py:372:             #TODO: joints will propably cause problems
./dxf2gcode/core/pocketmill.py:481:             #TODO: beans shape:  (____)
./dxf2gcode/core/pocketmill.py:483:             #TODO: "Only lines and <180 angle.
./dxf2gcode/core/pocketmill.py:666:             #TODO: convert it to move based on horizontal and vertical lines only
./dxf2gcode/core/pocketmill.py:720:             #TODO: tweak?
./dxf2gcode/core/pocketmill.py:732:             #TODO: compensation type 41
./dxf2gcode/core/shape.py:241:                  #TODO: end point will change to zig-zag's end
./dxf2gcode/core/rapidmove.py:96:               #TODO: going Z-up can be done as full speed?
./dxf2gcode/globals/config.py:42:               #TODO: check if can be removed: from dns.rdataclass import NONE

I need some help with original dxf2gcode [https://sourceforge.net/p/dxf2gcode/tickets/67/]:

My work is currently a bit stalled, but program works fine now. Not everything was tested yet (maybe I'm too lazy).
I might need Your help: I was wondering if we can add something like milling shape. I do not know how to call it, so I explain what I wish to see:
In main window, when shape is set to mill or pocket mill, the toolpath is shown with blue line, I would like to add another line of widith of 2 x tool_rad for example yellow with 60% transparency. So it will be very well seen how it will look after milling.
Second thing. I have added new class (RapidMove - I have another idea to make it work better, as it does not disable machine tool compensation for pocket milling, so name will change) that can be appended. The effect is that it is not well shown, as it seems to be ignored. Where is function that displays toolpath, so I can fix this?

And lots of tests. If You find some errors or have ideas, please write it here:  https://groups.google.com/forum/#!topic/dxf2gcode-users/wZfk-CgDXVw

Regards!

[Christian]

Hi San,

 

thanks for the great work you did. I’m sorry that i Reply that late, but i had to get my 3d Printer running 😊 with Cura. I’m still not there, so my time is actually a bit limited in the next few weeks …

 

However i’m happy to see that Thing are progressing and i would even propose to integrate your changes in the development branch, if the others see not reason not to do it. I think this would enable the biggest community to test it. Even going beyond this we could compile a windows executable which even increases the people testing much more. What is your opinion about that – may be eben to much in the current state.

 

I can try to help you out with the existing code, but i’m not the specialist with all of that topics.

 

My work is currently a bit stalled, but program works fine now. Not everything was tested yet (maybe I'm too lazy).
I might need Your help: I was wondering if we can add something like milling shape. I do not know how to call it, so I explain what I wish to see:
In main window, when shape is set to mill or pocket mill, the toolpath is shown with blue line, I would like to add another line of widith of 2 x tool_rad for example yellow with 60% transparency. So it will be very well seen how it will look after milling.

• I think the links provided below do Show how you might do it.

Second thing. I have added new class (RapidMove - I have another idea to make it work better, as it does not disable machine tool compensation for pocket milling, so name will change) that can be appended. The effect is that it is not well shown, as it seems to be ignored. Where is function that displays toolpath, so I can fix this?

• Hope the links below do help. I didn’t fully get the Question.

 

The function which draws the canvas is here:

https://sourceforge.net/p/dxf2gcode/sourcecode/ci/master/tree/source/dxf2gcode.py#l892

 

calling 2d:

https://sourceforge.net/p/dxf2gcode/sourcecode/ci/master/tree/source/dxf2gcode/gui/canvas2d.py#l285

 

or calling 3d:

https://sourceforge.net/p/dxf2gcode/sourcecode/ci/master/tree/source/dxf2gcode/gui/canvas3d.py#l465

 

Regards

Christian

--
--
You received this message because you subscribed to the Google
Groups-group "dxf2gcode-dev".
To post a message, send mail to dxf2gc...@googlegroups.com
To unsubscribe, send mail to dxf2gcode-de...@googlegroups.com
See http://groups.google.de/group/dxf2gcode-dev?hl=en for more options
and the dxf2gcode project page at http://code.google.com/p/dxf2gcode/
---
You received this message because you are subscribed to the Google Groups "dxf2gcode-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dxf2gcode-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/dxf2gcode-dev/7cdc4999-a0a0-4a29-9350-907badad2b06%40googlegroups.com.

 

[San Zamoyski]

thanks for the great work you did. I’m sorry that i Reply that late, but i had to get my 3d Printer running 😊 with Cura. I’m still not there, so my time is actually a bit limited in the next few weeks …

 My thesis defense will be in two weeks and the wedding in half a year, so I also have limited time resources ;)

However i’m happy to see that Thing are progressing and i would even propose to integrate your changes in the development branch, if the others see not reason not to do it. I think this would enable the biggest community to test it. Even going beyond this we could compile a windows executable which even increases the people testing much more. What is your opinion about that – may be eben to much in the current state.

I would love to! But hold on a second, as I want to add "disable tool compensation before pocket and reenable after", so it will also work if "tool compensation is done by machine".

I'll it here when I'm done.

I can try to help you out with the existing code, but i’m not the specialist with all of that topics.

I'm somehow unable to dig into those functions to find part of code which makes blue lines on the screen... I'll try that again, but later, as it can be marked non-critical.

Regards!

[Christian]

Hi San,

 

see my feedback below …

 

thanks for the great work you did. I’m sorry that i Reply that late, but i had to get my 3d Printer running 😊 with Cura. I’m still not there, so my time is actually a bit limited in the next few weeks …

 

 My thesis defense will be in two weeks and the wedding in half a year, so I also have limited time resources ;)

• Good luck (or i hope you Need None, which is even better 😊)

However i’m happy to see that Thing are progressing and i would even propose to integrate your changes in the development branch, if the others see not reason not to do it. I think this would enable the biggest community to test it. Even going beyond this we could compile a windows executable which even increases the people testing much more. What is your opinion about that – may be eben to much in the current state.

 

I would love to! But hold on a second, as I want to add "disable tool compensation before pocket and reenable after", so it will also work if "tool compensation is done by machine".

I'll it here when I'm done.

• Ok, i will wait until you come back …

 

I can try to help you out with the existing code, but i’m not the specialist with all of that topics.

 

I'm somehow unable to dig into those functions to find part of code which makes blue lines on the screen... I'll try that again, but later, as it can be marked non-critical.

• I will support you there, at least with 2d (in first step). We just need to know where those lines are saved which you want to plot ….

 

Regards!

--
--
You received this message because you subscribed to the Google
Groups-group "dxf2gcode-dev".
To post a message, send mail to dxf2gc...@googlegroups.com
To unsubscribe, send mail to dxf2gcode-de...@googlegroups.com
See http://groups.google.de/group/dxf2gcode-dev?hl=en for more options
and the dxf2gcode project page at http://code.google.com/p/dxf2gcode/
---
You received this message because you are subscribed to the Google Groups "dxf2gcode-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dxf2gcode-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/dxf2gcode-dev/a65f7e97-40ab-4581-b644-3ff1f9146a9f%40googlegroups.com.

 

[San Zamoyski]

 My thesis defense will be in two weeks and the wedding in half a year, so I also have limited time resources ;)

• Good luck (or i hope you Need None, which is even better 😊)

thanks! 

I would love to! But hold on a second, as I want to add "disable tool compensation before pocket and reenable after", so it will also work if "tool compensation is done by machine".

I'll it here when I'm done.

• Ok, i will wait until you come back …

I'm still here! I've spend few hours trying to solve this problem and then realised it is... pointless (my solution was pointless, not the idea). So I just disabled PM when compensation by machine is set and noted it in config file.  

•  I can try to help you out with the existing code, but i’m not the specialist with all of that topics. 

I'm somehow unable to dig into those functions to find part of code which makes blue lines on the screen... I'll try that again, but later, as it can be marked non-critical.

• I will support you there, at least with 2d (in first step). We just need to know where those lines are saved which you want to plot ….

They are simply added to geos list by eg. self.stmove.append(RapidMove(realStart)) as RapidMove instance. It is initialised as:

class RapidMove(Point):

    def __init__(self, point):

        Point.__init__(self, point.x, point.y)

        self.abs_geo = None

        

        self.feedZ = 0

        self.feedXY = 0

        self.safe = 0

        self.depth = 0

        self.retr = 0

To be honest, I just copied RapidPos class and modified it (especially Write_GCode function).

[San Zamoyski]

Found it!

It was hidden in RapidMove class as function make_path. I've converted it into PocketMove class (and some small minor changes) and now path is shown quite correct.

I've moved it from Beta branch to Release Candidate here: https://github.com/SanZamoyski/dxf2gcode-pocketMill/tree/RC1

I think it is quite ready, yet there is a lot to make it even cooler. ;)

[Christian Kohlöffel]

I try to test it and integrate it into zu the development branch on the weekend. 

Regards CHRISTIAN

--

--
You received this message because you subscribed to the Google
Groups-group "dxf2gcode-dev".
To post a message, send mail to dxf2gc...@googlegroups.com
To unsubscribe, send mail to dxf2gcode-de...@googlegroups.com
See http://groups.google.de/group/dxf2gcode-dev?hl=en for more options
and the dxf2gcode project page at http://code.google.com/p/dxf2gcode/
---
You received this message because you are subscribed to the Google Groups "dxf2gcode-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dxf2gcode-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/dxf2gcode-dev/9b16d9ee-34bf-4e12-a984-5d2f25a16bc4%40googlegroups.com.

[San Zamoyski]

I try to test it and integrate it into zu the development branch on the weekend.

Updated comments for code explanations and TODOs. 

[Christian]

Hi,

 

i tried to merge then proposed RC1 from San into the development branch, but i am not a good git user and therefore i failed to do it. Can anyone help me on that and do it for me?

 

Thank you in Advance

 

Christian

--

--
You received this message because you subscribed to the Google
Groups-group "dxf2gcode-dev".
To post a message, send mail to dxf2gc...@googlegroups.com
To unsubscribe, send mail to dxf2gcode-de...@googlegroups.com
See http://groups.google.de/group/dxf2gcode-dev?hl=en for more options
and the dxf2gcode project page at http://code.google.com/p/dxf2gcode/
---
You received this message because you are subscribed to the Google Groups "dxf2gcode-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dxf2gcode-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/dxf2gcode-dev/45ec9889-d6de-4e34-aa91-f171af3b3ecb%40googlegroups.com.

 

[San Zamoyski]

I am also a poor GitHub user. I'm trying to learn it a bit on this occasion. ;)

What help do You need?

[Christian Kohlöffel]

I know how to integrate a Branch from same repository, but how do I integrate a fork. Eclipse doesn't have such an option I think. Do I need a different tool or ?

I will ask Google this evening, maybe this will enlighten me

Regards Christian

San Zamoyski <niepamie...@gmail.com> schrieb am Mo., 27. Jan. 2020, 14:27:

I am also a poor GitHub user. I'm trying to learn it a bit on this occasion. ;)

What help do You need?

--

--
You received this message because you subscribed to the Google
Groups-group "dxf2gcode-dev".
To post a message, send mail to dxf2gc...@googlegroups.com
To unsubscribe, send mail to dxf2gcode-de...@googlegroups.com
See http://groups.google.de/group/dxf2gcode-dev?hl=en for more options
and the dxf2gcode project page at http://code.google.com/p/dxf2gcode/
---
You received this message because you are subscribed to the Google Groups "dxf2gcode-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dxf2gcode-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/dxf2gcode-dev/c910afe3-910b-497e-8305-953f444485e7%40googlegroups.com.

[Christian]

OK, now I think I understand a bit more, this is no fork, San do i guess right you just downloaded the files and modified them in your new git repository. Therefore there  is no link remaining to the reference right? Do you know if there are any changes since you did that? What Version did you use, did you start with the development branch which was valid 2 months ago? Therefore all the last changes in current branch? If not can you add them in there?

 

 

I would therefore if it’s based on newest Version just copy it to the development branch and do a commit with that Version. So all the history Information lost which was generated in the repository of San.

 

Does anyone have another way to do it better?

 

Regards

Christian

 

Von: Christian Kohlöffel
Gesendet: Montag, 27. Januar 2020 16:20
An: 'Timo Birnschein' via dxf2gcode-dev
Betreff: Re: [dxf2gcode-dev] Pocket milling (dev help)

 

I know how to integrate a Branch from same repository, but how do I integrate a fork. Eclipse doesn't have such an option I think. Do I need a different tool or ?

[San Zamoyski]

OK, now I think I understand a bit more, this is no fork, San do i guess right you just downloaded the files and modified them in your new git repository. Therefore there  is no link remaining to the reference right? Do you know if there are any changes since you did that? What Version did you use, did you start with the development branch which was valid 2 months ago? Therefore all the last changes in current branch? If not can you add them in there?

I've downloaded dxf2gcode-20191025.zip version, uploaded it on gitHub and modified.

Fortunately most of modifications are packed into two new files (I always try to do modifications that way).

Unfortunately I'm currently loaded with other work, but if there is something I can do, please write.

[Christian]

Hi San,

 

Good to hear that you used the newest Version, that really helped a lot. I just reviewed all the files and uploaded them on a new branch in the git repository:

https://sourceforge.net/p/dxf2gcode/sourcecode/ci/PocketMill-new/tree/

 

Can you please check wheatear i did get all of the changes, just to be sure 😊 ....

 

After you checked that branch i will make it the development branch. Starting from there i would propose that you work directly in the development branch for any further changes, that would make it a bit easier for all i think. Do you already have an account on SourceForge which one i can add?

 

Regards

Christian

 

Ps: I would even propose to give you admin rights, in order to have full edit capabilities, what do yo think about it?

 

Von: San Zamoyski
Gesendet: Mittwoch, 29. Januar 2020 11:56
An: dxf2gcode-dev
Betreff: Re: [dxf2gcode-dev] Pocket milling (dev help)

 

 

OK, now I think I understand a bit more, this is no fork, San do i guess right you just downloaded the files and modified them in your new git repository. Therefore there  is no link remaining to the reference right? Do you know if there are any changes since you did that? What Version did you use, did you start with the development branch which was valid 2 months ago? Therefore all the last changes in current branch? If not can you add them in there?

--

--
You received this message because you subscribed to the Google
Groups-group "dxf2gcode-dev".
To post a message, send mail to dxf2gc...@googlegroups.com
To unsubscribe, send mail to dxf2gcode-de...@googlegroups.com
See http://groups.google.de/group/dxf2gcode-dev?hl=en for more options
and the dxf2gcode project page at http://code.google.com/p/dxf2gcode/
---
You received this message because you are subscribed to the Google Groups "dxf2gcode-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dxf2gcode-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/dxf2gcode-dev/1d97a738-cee5-4745-85fe-0beb232dc6fc%40googlegroups.com.

 

[San Zamoyski]

Everything seems to be ok.

Good luck (or i hope you Need None, which is even better 😊)

I've succeed!

  

Can you please check wheatear i did get all of the changes, just to be sure 😊 ....

You missed some of my comments ;)

And translations. I do not know if it was by purpose.

 

After you checked that branch i will make it the development branch. Starting from there i would propose that you work directly in the development branch for any further changes, that would make it a bit easier for all i think. Do you already have an account on SourceForge which one i can add?

https://sourceforge.net/u/sanzamoyski/profile

  

Ps: I would even propose to give you admin rights, in order to have full edit capabilities, what do yo think about it?

 

I'm not familar with SF at all, but I might try ;)

Maybe not FULL edit capabilities, but to moderate?

 

 

Von: San Zamoyski
Gesendet: Mittwoch, 29. Januar 2020 11:56
An: dxf2gcode-dev
Betreff: Re: [dxf2gcode-dev] Pocket milling (dev help)

 

 

OK, now I think I understand a bit more, this is no fork, San do i guess right you just downloaded the files and modified them in your new git repository. Therefore there  is no link remaining to the reference right? Do you know if there are any changes since you did that? What Version did you use, did you start with the development branch which was valid 2 months ago? Therefore all the last changes in current branch? If not can you add them in there?

 

I've downloaded dxf2gcode-20191025.zip version, uploaded it on gitHub and modified.

Fortunately most of modifications are packed into two new files (I always try to do modifications that way).

Unfortunately I'm currently loaded with other work, but if there is something I can do, please write.

--
--
You received this message because you subscribed to the Google
Groups-group "dxf2gcode-dev".
To post a message, send mail to dxf2gc...@googlegroups.com

To unsubscribe, send mail to dxf2gc...@googlegroups.com

See http://groups.google.de/group/dxf2gcode-dev?hl=en for more options
and the dxf2gcode project page at http://code.google.com/p/dxf2gcode/
---
You received this message because you are subscribed to the Google Groups "dxf2gcode-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to dxf2gc...@googlegroups.com.

[Ok Thierry]

Hi all, we're working on a DXF 2GCODE 2MACHINE in the cloud. In short, helping some folks in schools and maker spaces to have an easy intro to producing designs. It's nearly working except for Pocketing. We tried the different implementations of Pocketing (Including San Zamoyski's implementation) but had no luck. We can't get the pocketing to work nor use it via layer control. Looking out for help!

[Christian Kohlöffel]

Hi Thierry,

 

can you be a bit more precise on that. I just tried it on a quiete complex geometry I think and had no issues with it, see attached picture.

 

Regards

Christian  

 

To unsubscribe, send mail to dxf2gcode-de...@googlegroups.com

See http://groups.google.de/group/dxf2gcode-dev?hl=en for more options
and the dxf2gcode project page at http://code.google.com/p/dxf2gcode/
---
You received this message because you are subscribed to the Google Groups "dxf2gcode-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to dxf2gcode-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/dxf2gcode-dev/073bd506-8d47-4603-90ea-a5b7189e26c9n%40googlegroups.com.

[Ok Thierry]

Hi Christian, 

It works on the desktop version on Windows, not on mac. That's fine. Maybe we didn't see the right settings on Mac but so far it is not a blocker. 

Since we are working on a UI-less version for the cloud (no human clicking), we're struggling to get the pocketing to work using the LayerControl function. Milling and Drilling is working with the LayerControl but not pocketing. 
Has anyone used LayerControl for Pocketing operations? 



Here is the GCODE: https://drive.google.com/drive/folders/1BaDKMGXjfvnizfJmh7Ku1kR7wx-4ZdkG?usp=sharing 

All the best, 
Thierry 

[Ok Thierry]

Hi again,

One small question regarding Pocket Milling on MAC: If you look at the image (Windows in Clear and Mac in Dark), 

you can see that the description text is different between Windows and Mac. Is there a reason for that? 

The text in Windows includes ("This also disables pocket miling"). 



Best,
Thierry 

[Christian Kohlöffel]

Hi Thierry,

 

maybe they are base on different version? I am not sure. But they should be the same …

 

Regarding the other topic:

the LayerControl function has been implemented long before the very new Pocketing operations. The Pocketing is still in development / beta. I don’t think that this is integrated up to now, at least I didn’t find it in the code:

 

Here you find the LayerControl functionality:

https://sourceforge.net/p/dxf2gcode/sourcecode/ci/develop/tree/source/dxf2gcode/core/layercontent.py#l87

 

Here you find the Point where automatic cutter compensation is done:

https://sourceforge.net/p/dxf2gcode/sourcecode/ci/develop/tree/source/dxf2gcode.py#l910

 

There is not much more which is done I guess. Therefore no pocketing called by any automatic means I guess. I hope this helps you ….

 

Regards

Christian

To view this discussion on the web visit https://groups.google.com/d/msgid/dxf2gcode-dev/49e3588a-4984-43a2-8eba-5a2fd7dab33cn%40googlegroups.com.

[Ok Thierry]

Hi Chris, 

Thank you for the guidance. It helped us to update that feature and it worked. PocketMill works with LayerControl. It also runs on mac (Linux) and in the cloud. We'll publish the code once we tested it a little more. 

Cheers,
Thierry 

[Christian Kohlöffel]

Hi Thierry,

 

that sound great, waiting for your update. I could also grant you developer rights to directly merge it into the development branch …

 

best regards

To view this discussion on the web visit https://groups.google.com/d/msgid/dxf2gcode-dev/f9bec54f-cef5-427a-8ac0-7f9f731221a8n%40googlegroups.com.

[Ok Thierry]

Hello Christian, 

Could you give Manoj (I send you his email) the developer rights? He will do the merging. 

All the best,

Thierry 

[Ok Thierry]

Hi all, 

It is not related to the Pocketing but kind of a continuity of this discussion. Since the Auto Tool Compensation wasn't working for us (and not working with Pocketing), we decided to automatize the tool compensation using the LayerControl. 
When possible, we will merge the code with the CutLine functionality Manoj built for the Layer Control. It allows one to define in the layer name which tool compensation to apply to the layer. 

Cheers,
Thierry