Proposal - Disable coveralls

39 views
Skip to first unread message

Charles Allen

unread,
Jun 7, 2016, 6:15:11 PM6/7/16
to Druid Development
Coveralls hasn't seen much attention, is believed to be inaccurate for many comparisons of coverage changes (potentially comparing prior coveralls run instead of prior master run), and can cause stalls in the build process: https://github.com/druid-io/druid/issues/3067

This proposal is to disable coveralls for druid-io/druid

Xavier Léauté

unread,
Jun 7, 2016, 6:24:39 PM6/7/16
to druid-de...@googlegroups.com
If cobertura is the underlying problem, we could try giving jacoco a shot, it seems to be more actively maintained and also has better Java 8 support already.

On Tue, Jun 7, 2016 at 3:15 PM, Charles Allen <charle...@metamarkets.com> wrote:
Coveralls hasn't seen much attention, is believed to be inaccurate for many comparisons of coverage changes (potentially comparing prior coveralls run instead of prior master run), and can cause stalls in the build process: https://github.com/druid-io/druid/issues/3067

This proposal is to disable coveralls for druid-io/druid

--
You received this message because you are subscribed to the Google Groups "Druid Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to druid-developm...@googlegroups.com.
To post to this group, send email to druid-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/druid-development/fc01f08c-1414-4baa-b49f-4c67cb427b7f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Charles Allen

unread,
Jun 10, 2016, 1:48:26 PM6/10/16
to Druid Development
https://github.com/druid-io/druid/pull/3122 disables the feature in question. It can (and probably should) be re-enabled later with proper investigation into how to make it not block regular checks


On Tuesday, June 7, 2016 at 3:24:39 PM UTC-7, Xavier wrote:
If cobertura is the underlying problem, we could try giving jacoco a shot, it seems to be more actively maintained and also has better Java 8 support already.
On Tue, Jun 7, 2016 at 3:15 PM, Charles Allen <charle...@metamarkets.com> wrote:
Coveralls hasn't seen much attention, is believed to be inaccurate for many comparisons of coverage changes (potentially comparing prior coveralls run instead of prior master run), and can cause stalls in the build process: https://github.com/druid-io/druid/issues/3067

This proposal is to disable coveralls for druid-io/druid

--
You received this message because you are subscribed to the Google Groups "Druid Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to druid-development+unsubscribe@googlegroups.com.
To post to this group, send email to druid-development@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages