[4.1.0,4.1.1] The 411 on 4.1.1

Nathan Keiter

unread,

Sep 12, 2017, 9:20:35 AM9/12/17

to dot...@googlegroups.com

As an avid plugin developer, I appreciate when we are notified of important changes. Somehow this didn’t make it into the change logs. (https://dotcms.com/docs/latest/changelogs#release-4.1.0)

If you have any OSGI/static plugin that deals with relationships, the very useful “RelationshipFactory” has been refactored. Technically it is now an interface rather than a normal class. All access to the interface is now controlled by the FactoryLocator. Also for reasons unknown, the method signatures have all changed.

So the old code:

RelationshipFactory.getRelationshipByRelationTypeValue( x );

Is replaced by:

RelationshipFactory relationshipFactory = FactoryLocator.getRelationshipFactory();

relationshipFactory.byTypeValue( x );

OR

FactoryLocator.getRelationshipFactory().byTypeValue( x );

Just FYI. If I come across any more unpleasant surprises I’ll post them here.

https://www.gettysburg.edu

Nathan Keiter

unread,

Sep 12, 2017, 9:27:51 AM9/12/17

to dot...@googlegroups.com

Class path change:

OLD:

import com.dotmarketing.portlets.structure.factories.RelationshipFactory;

NEW:

import com.dotcms.contenttype.business.RelationshipFactory;

import com.dotmarketing.business.FactoryLocator;

https://www.gettysburg.edu

--
http://dotcms.com - Open Source Java Content Management
---
You received this message because you are subscribed to the Google Groups "dotCMS User Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dotcms+un...@googlegroups.com.
To post to this group, send email to dot...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/dotcms/f79516c864ec4906a30c87da8ec2946d%40exch13c.ms.gettysburg.edu.
For more options, visit https://groups.google.com/d/optout.

Nathan Keiter

unread,

Sep 12, 2017, 9:45:28 AM9/12/17

to dot...@googlegroups.com

Actually it looks like a core portlet JSP wasn’t adapted for the change either… I’ll create a ticket.

[12/09/17 09:41:09:475 EDT] ERROR portlet.PortletRequestDispatcherImpl: Unable to compile class for JSP:

An error occurred at line: [154] in the generated java file: [D:\websiteRoot\dotCMSRoot\dotserver\tomcat-8.0.18\work\Catalina\localhost\ROOT\org\apache\jsp\html\portlet\ext\contentlet\edit_005fcontentlet_005frelationships_jsp.java]

Only a type can be imported. com.dotmarketing.portlets.structure.factories.RelationshipFactory resolves to a package

An error occurred at line: 225 in the jsp file: /html/portlet/ext/contentlet/edit_contentlet_relationships.jsp

RelationshipFactory cannot be resolved

222: catch(Exception e){

223:

224: }

225: if(parent && RelationshipFactory.isSameStructureRelationship(rel, targetStructure)){

226: //continue;

227: }

228:

Stacktrace:

org.apache.jasper.JasperException: Unable to compile class for JSP:

An error occurred at line: [154] in the generated java file: [D:\websiteRoot\dotCMSRoot\dotserver\tomcat-8.0.18\work\Catalina\localhost\ROOT\org\apache\jsp\html\portlet\ext\contentlet\edit_005fcontentlet_005frelationships_jsp.java]

Only a type can be imported. com.dotmarketing.portlets.structure.factories.RelationshipFactory resolves to a package

An error occurred at line: 225 in the jsp file: /html/portlet/ext/contentlet/edit_contentlet_relationships.jsp

RelationshipFactory cannot be resolved

222: catch(Exception e){

223:

224: }

225: if(parent && RelationshipFactory.isSameStructureRelationship(rel, targetStructure)){

226: //continue;

227: }

228:

Stacktrace:

at org.apache.jasper.compiler.DefaultErrorHandler.javacError(DefaultErrorHandler.java:102) ~[jasper.jar:8.0.18]

at org.apache.jasper.compiler.ErrorDispatcher.javacError(ErrorDispatcher.java:198) ~[jasper.jar:8.0.18]

at org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:450) ~[jasper.jar:8.0.18]

at org.apache.jasper.compiler.Compiler.compile(Compiler.java:361) ~[jasper.jar:8.0.18]

at org.apache.jasper.compiler.Compiler.compile(Compiler.java:336) ~[jasper.jar:8.0.18]

at org.apache.jasper.compiler.Compiler.compile(Compiler.java:323) ~[jasper.jar:8.0.18]

at org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:570) ~[jasper.jar:8.0.18]

at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:356) ~[jasper.jar:8.0.18]

at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:396) ~[jasper.jar:8.0.18]

at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:340) ~[jasper.jar:8.0.18]

at javax.servlet.http.HttpServlet.service(HttpServlet.java:725) ~[servlet-api.jar:?]

at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:291) ~[catalina.jar:8.0.18]

at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) ~[catalina.jar:8.0.18]

at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:721) ~[catalina.jar:8.0.18]

at org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:584) ~[catalina.jar:8.0.18]

at org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:523) ~[catalina.jar:8.0.18]

at org.apache.jasper.runtime.JspRuntimeLibrary.include(JspRuntimeLibrary.java:934) ~[jasper.jar:8.0.18]

at org.apache.jsp.html.portlet.ext.contentlet.edit_005fcontentlet_jsp._jspService(edit_005fcontentlet_jsp.java:3312) ~[?:?]

at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) ~[jasper.jar:8.0.18]

at javax.servlet.http.HttpServlet.service(HttpServlet.java:725) ~[servlet-api.jar:?]

at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:431) ~[jasper.jar:8.0.18]