Potential admin bug

[Fab]

Hey,

In the admin when clicking "add model +" I fill out the fields to create my item then when I click "Save and add another" or "Save and continue editing" it redirects back to the model list view even though the item was added successfully. If I click back on to the item to edit it the buttons work how they should.

I'm not sure if this is a bug with the admin. I've tried it on 2 projects now. I'm using Django 4.1.

I uploaded a sample project so you can quickly see if the issue happens for you too.

https://github.com/fabtjar/django_admin_issue

Cheers,

Fab

[Ross Meredith]

It's more likely a set up problem than a bug I'd have thought.

If it helps here is the relevant code - https://github.com/django/django/blob/main/django/contrib/admin/options.py#L132.

def response_add is the method which determines what the response to use after a successful addition.

--
You received this message because you are subscribed to the Google Groups "Django users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-users...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-users/eb9cf313-a1c7-45b6-a254-f8f8bb4d3fddn%40googlegroups.com.

[Adebileje Nurudeen]

Okay... So what exactly do you need on it?

So I can just fix it

On Wed, Aug 3, 2022 at 7:09 PM Fab <fabian...@gmail.com> wrote:

--

[Adebileje Nurudeen]

I'll get back to you 

To view this discussion on the web visit https://groups.google.com/d/msgid/django-users/CAA1Tdz1T_C8AchfNNOCTv3CRCJFZAjNhHPyp2cvE76_OoZ_9NQ%40mail.gmail.com.

[Fab]

Looks like "_addanother" isn't in the request.POST: https://github.com/django/django/blob/main/django/contrib/admin/options.py#L1388

The name on the input isn't being passed with the form submit: https://github.com/django/django/blob/main/django/contrib/admin/templates/admin/submit_line.html#L6

If I comment out overriding the submit it works as expected: https://github.com/django/django/blob/main/django/contrib/admin/static/admin/js/change_form.js#L11:L19

[Fab]

Also when editing an item that has already been created "modelName" is undefined so the submit buttons don't get overridden: https://github.com/django/django/blob/main/django/contrib/admin/static/admin/js/change_form.js#L8
So works when editing, but not when adding a new item.

[Fab]

Maybe this change is causing the issue? https://github.com/django/django/commit/fe7dbef5867c577995f0fc849d8dfdb8f2e6bbfa

[Fabian Jarrett]

I've filed the bug now. I think I can fix it. https://code.djangoproject.com/ticket/33893