How do I know what version a patch is included in?

37 views
Skip to first unread message

Andrew Buchan

unread,
Dec 20, 2017, 1:32:52 PM12/20/17
to Django users
I'm being affected by this bug: https://code.djangoproject.com/ticket/28562 which was fixed 4 months ago.

Somewhere on the ticket page it says:

Version:1.11 → master
Which is the only reference to version I found anywhere on the page, so I assumed this meant the fix was in 1.11 

I've just spent 2 days going through a ridiculously difficult upgrade, only to find that this fix is not in 1.11!

So how do I know which version a given bug has been fixed in, short of examining the source code myself?

Jani Tiainen

unread,
Dec 20, 2017, 3:12:46 PM12/20/17
to django...@googlegroups.com
Hi.

Usually when ticket is closed there is a pointer to changeset which fixed the issue. When you look the changeset it should also contain a list of tags that are in effect in that changeset. 

By looking that ticket it was fixed in master branch and then backported to 2.0.x branch.

In this case it's not very obvious that issue is fixed in 2.0+


--
You received this message because you are subscribed to the Google Groups "Django users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-users+unsubscribe@googlegroups.com.
To post to this group, send email to django...@googlegroups.com.
Visit this group at https://groups.google.com/group/django-users.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-users/7838c495-3174-4393-a0e1-ca481e0596be%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Andrew Buchan

unread,
Dec 21, 2017, 5:07:42 AM12/21/17
to django...@googlegroups.com
I'm sorry, but I still don't see how you determined that. I can follow the merge request, and the commit, but I can find anything that links to a version from either of those, though this is getting into the arena of git. I know it's in 2.0 now, but am concerned that I wasn't able to find that out just by looking at the ticket.

The Django 2.0 release notes doesn't list the bugs fixed. 

I think this is a critically important piece of information for many developers. 

Django updates can be painful, especially if you have many plugins and are a few versions behind. So when you encounter a bug that requires an upgrade, many people would want to know the lowest version they need to upgrade to to obtain a given patch (yes yes, everyone should update to latest, but there are always reasons that can't be done, or trade-offs, which then become business decisions etc...)



--
You received this message because you are subscribed to a topic in the Google Groups "Django users" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/django-users/XamGT196Svc/unsubscribe.
To unsubscribe from this group and all its topics, send an email to django-users+unsubscribe@googlegroups.com.

To post to this group, send email to django...@googlegroups.com.
Visit this group at https://groups.google.com/group/django-users.

Jani Tiainen

unread,
Dec 21, 2017, 5:51:43 AM12/21/17
to django...@googlegroups.com
Hi.

Tickets do always have a reference to changeset (commit) where that ticket is fixed. All bugs are always fixed in master (dev version of django). Then depending on a case fix maybe backported to some previous version. In this particular case last commen contais changeset that contains backport.

Now you can click those changeset links to get to github and see changes itself. But you also see the branch changeset was applied and next to it is a list of tags within branch.

Since in this case issue was backported on 2.0.x branch and there is not a list of tags fix will be in 2.0.0

If there are tags fix will be on latest tag + 1. So if there would be tags like 2.0.1 2.0.2 fix would appear in 2.0.3.

But yes there isn't any direct indication between ticket and version(s) it's been fixed.

Andrew Buchan

unread,
Dec 21, 2017, 10:33:38 AM12/21/17
to Django users
Thanks, I think I understand...
Reply all
Reply to author
Forward
0 new messages