Admin css question for 1.10.7

Mike Dewhirst

unread,

May 7, 2017, 3:05:14 AM5/7/17

to Django users

I'm just (slowly) advancing from 1.8 to 1.11 and stopping for a short
while at 1.10.

I notice that help-text doesn't line up under the left edge of
DecimalField fields the way it does for TextFields and most others.

Is this a deliberate design decision?

Thanks

Mike

--
PLEASE NOTE OUR NEW LANDLINE IS +61 (0)3 9034 3977

Climate Pty Ltd
PO Box 308
Mount Eliza
Vic 3930
Australia +61

T: 03 9034 3977
M: 0411 704 143

Tim Graham

unread,

May 7, 2017, 10:12:17 AM5/7/17

to Django users

You can use git bisect to find the Django commit where the behavior changed:
https://docs.djangoproject.com/en/dev/internals/contributing/triaging-tickets/#bisecting-a-regression

Mike Dewhirst

unread,

May 7, 2017, 12:18:56 PM5/7/17

to django...@googlegroups.com

On 7/05/2017 8:12 PM, Tim Graham wrote:
> You can use git bisect to find the Django commit where the behavior
> changed:
> https://docs.djangoproject.com/en/dev/internals/contributing/triaging-tickets/#bisecting-a-regression

Just read this and I have two problems ...

1. It is a css problem resulting in help-text which is stepped in by
200px versus 160px and I can adjust that in the css file to make
everything line up again. However, the real problem here is I don't know
how to write a test for that.

2. I have (so far) no use for github and zero competence therein. I use
svn.

The workaround for problem 2 is to start looking backwards from 1.10.7
to see if I can visually inspect the css files. I can install different
versions and bisect manually.

However, maybe the change is in the widgets or the forms?

Thanks for any hints if you think that is the case.

Mike

>
> On Saturday, May 6, 2017 at 11:05:14 PM UTC-4, Mike Dewhirst wrote:
>
> I'm just (slowly) advancing from 1.8 to 1.11 and stopping for a short
> while at 1.10.
>
> I notice that help-text doesn't line up under the left edge of
> DecimalField fields the way it does for TextFields and most others.
>
> Is this a deliberate design decision?
>
> Thanks
>
> Mike
>
>
> --
> PLEASE NOTE OUR NEW LANDLINE IS +61 (0)3 9034 3977
>
> Climate Pty Ltd
> PO Box 308
> Mount Eliza
> Vic 3930
> Australia +61
>
> T: 03 9034 3977
> M: 0411 704 143
>
>

> --
> You received this message because you are subscribed to the Google
> Groups "Django users" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to django-users...@googlegroups.com
> <mailto:django-users...@googlegroups.com>.
> To post to this group, send email to django...@googlegroups.com
> <mailto:django...@googlegroups.com>.
> Visit this group at https://groups.google.com/group/django-users.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-users/77fb23ef-184d-4887-a3cb-01014a7e0392%40googlegroups.com
> <https://groups.google.com/d/msgid/django-users/77fb23ef-184d-4887-a3cb-01014a7e0392%40googlegroups.com?utm_medium=email&utm_source=footer>.
> For more options, visit https://groups.google.com/d/optout.

Mike Dewhirst

unread,

May 8, 2017, 2:01:19 AM5/8/17

to django...@googlegroups.com

Tim

The problem does not exist in 1.8.18 and does exist in 1.9

Here is the test I wrote to see if the css file contains the problem
(which I established by trial and error) ...

# -*- coding: utf-8 -*-
import os
from django.test import TestCase
from django.contrib import admin

expected = "form .wide p, form .wide input + p.help {"

class TestBadCss(TestCase):

def test_bad_css(self):
base_css = 'static/admin/css/forms.css'
exists = False
stradmin = str(admin)
pth = os.path.split(stradmin.split()[-1].split("'")[-2])[0]
base_css = os.path.join(pth, base_css).replace("\\","/")
#print("\n%s" % base_css)
if os.path.isfile(base_css):
lines = list()
with open(base_css, "r") as base:
lines = base.readlines()
for line in lines:
exists = expected in line
if exists:
break
self.assertEqual(exists, False)

I installed git and tried to do the bisecting thing but that didn't work
for me

(xxex3) C:\Users\mike\env\xxex3\ssds>git bisect bad
fatal: Not a git repository (or any of the parent directories): .git

Where should I go next?

Thanks

Mike

On 7/05/2017 8:12 PM, Tim Graham wrote:

Tim Graham

unread,

May 8, 2017, 10:57:01 AM5/8/17

to Django users

You need to clone the Django repository and run the bisect command from there: https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/unit-tests/

That said, you might have some luck using the "Blame" button on https://github.com/django/django/blob/stable/1.9.x/django/contrib/admin/static/admin/css/forms.css
That'll take you take a page that shows the latest change for each line.

Melvyn Sopacua

unread,

May 8, 2017, 1:04:19 PM5/8/17

to django...@googlegroups.com

On Monday 08 May 2017 03:57:01 Tim Graham wrote:

> You need to clone the Django repository and run the bisect command

> from there:

Simplicity in Unix:

1 #!/bin/sh

2

3 # Basically, make grep -qv behave like I want it to

4

5 file='django/contrib/admin/static/admin/css/forms.css'

6 bad='form .wide p, form .wide input + p.help {'

7

8 fgrep -q "$bad" $file

9 if [ $? -eq 0 ]

10 then

11 exit 1

12 else

13 exit 0

14 fi

Results:

% git bisect start 2c3c029ede 0b9f366c60

Bisecting: a merge base must be tested

[39d95fb6ada99c59d47fa0eae6d3128abafe2d58] Fixed #24092 -- Widened base field support for ArrayField.

% git bisect run `pwd`/invert.sh