Re: [Django] #3544: Fix {% include %} to allow recursive includes
Django
-------------------------------------+-------------------------------------
Reporter: David | Owner: nobody
Danier <goliath.mailinglist@…> | Status: new
Type: New | Component: Template system
feature | Severity: Normal
Milestone: | Keywords: tplrf-patched
Version: SVN | Has patch: 0
Resolution: | Needs tests: 1
Triage Stage: Accepted | Easy pickings: 0
Needs documentation: 1 |
Patch needs improvement: 1 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by Mnewman):
* cc: newmaniese@… (added)
* ui_ux: => 0
* easy: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/3544#comment:26>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: David | Owner: nobody
Danier <goliath.mailinglist@…> | Status: new
Type: New | Component: Template system
feature | Severity: Normal
Milestone: | Keywords: tplrf-patched
Version: SVN | Has patch: 0
Resolution: | Needs tests: 1
Triage Stage: Accepted | Easy pickings: 0
Needs documentation: 1 |
Patch needs improvement: 1 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Comment (by David Danier <david.danier@…>):
Needed this again and decided, that you currently can use
{{{
{% with template_name="file/to_include.html" %}{% include template_name
%}{% endwith %}
}}}
as an easy workaround.
--
Ticket URL: <https://code.djangoproject.com/ticket/3544#comment:27>
Django
-------------------------------------+-------------------------------------
<goliath.mailinglist@…> | Status: new
Type: New feature | Version: SVN
Component: Template system | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: tplrf-patched | Needs documentation: 1
Has patch: 0 | Patch needs improvement: 1
Needs tests: 1 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by camilonova):
We should include this patch or document the workaround, it is needed when
you want to render information in a tree format, like the comments
--
Ticket URL: <https://code.djangoproject.com/ticket/3544#comment:28>
Django
-------------------------------------+-------------------------------------
Reporter: David Danier | Owner: nobody
<goliath.mailinglist@…> | Status: new
Type: New feature | Version: SVN
Component: Template system | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: tplrf-patched | Needs documentation: 1
Has patch: 0 | Patch needs improvement: 1
Needs tests: 1 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by prestontimmons):
I added a patch to #16147.
It also addresses the problem of this patch, and lets includes happen
recursively.
--
Ticket URL: <https://code.djangoproject.com/ticket/3544#comment:29>
Django
-------------------------------------+-------------------------------------
Reporter: David Danier | Owner: nobody
<goliath.mailinglist@…> | Status: new
Severity: Normal | Triage Stage: Accepted
Keywords: tplrf-patched | Needs documentation: 1
Has patch: 0 | Patch needs improvement: 1
Needs tests: 1 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* cc: cvrebert (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/3544#comment:30>
Django
-------------------------------------+-------------------------------------
Reporter: David Danier | Owner: nobody
<goliath.mailinglist@…> | Status: new
Type: New feature | Version: master
Component: Template system | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: tplrf-patched | Needs documentation: 1
Has patch: 0 | Patch needs improvement: 1
Needs tests: 1 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by anonymous):
Any progress?
It seems quite demanded feature as soon as you deal with hierarchical
trees rendering.
--
Ticket URL: <https://code.djangoproject.com/ticket/3544#comment:31>
Django
-------------------------------------+-------------------------------------
Reporter: David Danier | Owner: nobody
<goliath.mailinglist@…> | Status: new
Type: New feature | Version: master
Component: Template system | Resolution:
Severity: Normal | Triage Stage: Accepted
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by prestontimmons):
* needs_better_patch: 1 => 0
* has_patch: 0 => 1
* needs_tests: 1 => 0
* needs_docs: 1 => 0
Comment:
Updated the patch and added a pull request for review.
https://github.com/django/django/pull/920
--
Ticket URL: <https://code.djangoproject.com/ticket/3544#comment:32>
Django
-------------------------------------+-------------------------------------
Reporter: David Danier | Owner: nobody
<goliath.mailinglist@…> | Status: new
Type: New feature | Version: master
Component: Template system | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: tplrf-patched | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by FunkyBob):
Whilst I agree we no longer need the separate classes, as we have the
caching template loader to cover the performance gain, I do question the
need for the "quiet" flag.
Under what circumstances do you seen someone wanting to do an include on a
template that may not exist?
--
Ticket URL: <https://code.djangoproject.com/ticket/3544#comment:33>
Django
-------------------------------------+-------------------------------------
Reporter: David Danier | Owner: nobody
<goliath.mailinglist@…> | Status: new
Type: New feature | Version: master
Component: Template system | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: tplrf-patched | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* cc: FunkyBob (added)
Comment:
I've made a PR for a simpler patch for this:
https://github.com/django/django/pull/1528
--
Ticket URL: <https://code.djangoproject.com/ticket/3544#comment:34>
Django
-------------------------------------+-------------------------------------
Reporter: David Danier | Owner: nobody
<goliath.mailinglist@…> | Status: new
Type: New feature | Version: master
Component: Template system | Resolution:
Keywords: tplrf-patched | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by loic84):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/3544#comment:35>
Django
-------------------------------------+-------------------------------------
Reporter: David Danier | Owner: nobody
Type: New feature | Version: master
Severity: Normal | Triage Stage: Ready for
Keywords: tplrf-patched | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"e2f06226ea4a38377cdb69f2f5768e4e00c2d88e"]:
{{{
#!CommitTicketReference repository=""
revision="e2f06226ea4a38377cdb69f2f5768e4e00c2d88e"
Improved {% include %} implementation
Merged BaseIncludeNode, ConstantIncludeNode and Include node.
This avoids raising TemplateDoesNotExist at parsing time, allows recursion
when passing a literal template name, and should make TEMPLATE_DEBUG
behavior
consistant.
Thanks loic84 for help with the tests.
Fixed #3544, fixed #12064, fixed #16147
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/3544#comment:36>